Mojo: introducing a thread safe interface pointer.

mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

 {%- import "interface_macros.tmpl" as interface_macros %}
 {%- import "struct_macros.tmpl" as struct_macros %}
 
 {%- set class_name = interface.name %}
 {%- set proxy_name = interface.name ~ "Proxy" %}
 {%- set namespace_as_string = "%s"|format(namespace|replace(".","::")) %}
 
 {%- macro alloc_params(struct, params, message, serialization_context,
                        description) %}
   ({{serialization_context}})->handles.Swap(({{message}})->mutable_handles());
@@ skipping 141 matching lines @@
 
 {%- for method in interface.methods %}
 {%-   set message_name =
           "internal::k%s_%s_Name"|format(interface.name, method.name) %}
 {%-   set params_struct = method.param_struct %}
 {%-   set params_description =
           "%s.%s request"|format(interface.name, method.name) %}
 {%-   if method.sync %}
 bool {{proxy_name}}::{{method.name}}(
     {{interface_macros.declare_sync_method_params("param_", method)}}) {
+   mojo::internal::SerializationContext serialization_context;
+   serialization_context.group_controller = group_controller_;

[yzshen1, 2016/11/15 18:53:46]

nit: please directly pass the group controller to the constructor of the
serialization context.

(here and elsewhere)

[Jay Civelli, 2016/11/15 19:36:38]

Done.

   {{struct_macros.get_serialized_size(params_struct, "param_%s",
-                                      "&serialization_context_")}}
+                                      "&serialization_context")}}
 
   mojo::internal::RequestMessageBuilder builder({{message_name}}, size,
                                                 mojo::Message::kFlagIsSync);
 
   {{build_message(params_struct, "param_%s", params_description,
-                  "&serialization_context_")}}
+                  "&serialization_context")}}
 
   bool result = false;
   mojo::MessageReceiver* responder =
       new {{class_name}}_{{method.name}}_HandleSyncResponse(
-          serialization_context_.group_controller, &result
+          group_controller_.get(), &result

[yzshen1, 2016/11/15 18:53:46]

I think .get() is not needed?

[Jay Civelli, 2016/11/15 19:36:38]

Removed.

 {%-     for param in method.response_parameters -%}
           , param_{{param.name}}
 {%-     endfor %});
   if (!receiver_->AcceptWithResponder(builder.message(), responder))
     delete responder;
   return result;
 }
 {%-   endif %}
 
 void {{proxy_name}}::{{method.name}}(
     {{interface_macros.declare_request_params("in_", method)}}) {
+   mojo::internal::SerializationContext serialization_context;
+   serialization_context.group_controller = group_controller_;
   {{struct_macros.get_serialized_size(params_struct, "in_%s",
-                                      "&serialization_context_")}}
+                                      "&serialization_context")}}
 
 {%- if method.response_parameters != None %}
   mojo::internal::RequestMessageBuilder builder({{message_name}}, size);
 {%- else %}
   mojo::internal::MessageBuilder builder({{message_name}}, size);
 {%- endif %}
 
   {{build_message(params_struct, "in_%s", params_description,
-                  "&serialization_context_")}}
+                  "&serialization_context")}}
 
 {%- if method.response_parameters != None %}
   mojo::MessageReceiver* responder =
       new {{class_name}}_{{method.name}}_ForwardToCallback(
-          callback, serialization_context_.group_controller);
+          callback, group_controller_.get());
   if (!receiver_->AcceptWithResponder(builder.message(), responder))
     delete responder;
 {%- else %}
   bool ok = receiver_->Accept(builder.message());
   // This return value may be ignored as !ok implies the Connector has
   // encountered an error, which will be visible through other means.
   ALLOW_UNUSED_LOCAL(ok);
 {%- endif %}
 }
 {%- endfor %}
@@ skipping 228 matching lines @@
       break;
   }
 
   // Unrecognized message.
   ReportValidationError(
       &validation_context,
       mojo::internal::VALIDATION_ERROR_MESSAGE_HEADER_UNKNOWN_METHOD);
   return false;
 }
 {%- endif -%}