Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2498703002:
Increase Max Range for RasterPixelsPerMs (Closed)
DescriptionIncrease Max Range for RasterPixelsPerMs
Increase the max ranger to 100M.
BUG=
R=ericrk
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Committed: https://crrev.com/323ed90f6d5b205f591493e61c7be6813be6665a
Cr-Commit-Position: refs/heads/master@{#435052}
Patch Set 1 #
Total comments: 2
Patch Set 2 : add 2 to histogram names #Patch Set 3 : rebase #Patch Set 4 : fix histogram name #
Messages
Total messages: 26 (12 generated)
Description was changed from ========== Increase Max Range for RasterPixelsPerMs Increase the max ranger to 100M. BUG= R=ericrk ========== to ========== Increase Max Range for RasterPixelsPerMs Increase the max ranger to 100M. BUG= R=ericrk CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
ericrk@chromium.org changed reviewers: + isherman@chromium.org
LGTM % my question fro isherman@ https://codereview.chromium.org/2498703002/diff/1/cc/base/histograms.h File cc/base/histograms.h (right): https://codereview.chromium.org/2498703002/diff/1/cc/base/histograms.h#newcode69 cc/base/histograms.h:69: 100000000, 50); \ isherman@ - when we update the range of an existing histogram, do we typically rename (add 2, etc...) to prevent confusion? Or just add a note for the sheriff when submitting?
https://codereview.chromium.org/2498703002/diff/1/cc/base/histograms.h File cc/base/histograms.h (right): https://codereview.chromium.org/2498703002/diff/1/cc/base/histograms.h#newcode69 cc/base/histograms.h:69: 100000000, 50); \ On 2016/11/14 17:33:32, ericrk wrote: > isherman@ - when we update the range of an existing histogram, do we typically > rename (add 2, etc...) to prevent confusion? Or just add a note for the sheriff > when submitting? You should rename, yes. Otherwise, the dashboard will show a confusing mix of buckets under the same name.
Added 2 to the new histogram names.
still LGTM - thanks for updating!
LGTM, thanks.
The CQ bit was checked by weiliangc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by weiliangc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by weiliangc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
The CQ bit was checked by weiliangc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from isherman@chromium.org, ericrk@chromium.org Link to the patchset: https://codereview.chromium.org/2498703002/#ps60001 (title: "fix histogram name")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480443416673080,
"parent_rev": "73c884c1afc6d94bdd09e6dd8bb4cf2c3271642b", "commit_rev":
"287e97fdfc3a7b32cb386850428de1c64eaf7c3d"}
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Increase Max Range for RasterPixelsPerMs Increase the max ranger to 100M. BUG= R=ericrk CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Increase Max Range for RasterPixelsPerMs Increase the max ranger to 100M. BUG= R=ericrk CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/323ed90f6d5b205f591493e61c7be6813be6665a Cr-Commit-Position: refs/heads/master@{#435052} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/323ed90f6d5b205f591493e61c7be6813be6665a Cr-Commit-Position: refs/heads/master@{#435052} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
