Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Unified Diff: scripts/slave/recipe_modules/auto_bisect_staging/bisector.py

Issue 2498693002: Better error message when reference range yields no values. (Closed)
Patch Set: Surfacing result Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py b/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
index e04b708de0721f828ce9296e2982a5546b6d105f..d9f3fdd85b9ddb646fc251cda147c2428a59f962 100644
--- a/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
@@ -508,12 +508,17 @@ class Bisector(object):
self._raise_low_confidence_error()
def _raise_low_confidence_error(self):
+ if (not self.good_rev.debug_values or
+ not self.bad_rev.debug_values): # pragma: no cover
+ msg = 'No values were found while testing the reference range.'
+ self.surface_result('MISSING_METRIC')
+ else:
+ msg = 'Bisect failed to reproduce the regression with enough confidence.'
+ self.surface_result('LO_INIT_CONF')
self.surface_result('REF_RANGE_FAIL')
- self.surface_result('LO_INIT_CONF')
self.failed = True
self.failed_initial_confidence = True
- raise bisect_exceptions.InconclusiveBisectException(
- 'Bisect failed to reproduce the regression with enough confidence.')
+ raise bisect_exceptions.InconclusiveBisectException(msg)
def get_exception(self):
raise NotImplementedError() # pragma: no cover
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698