Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2498673003: Rewrite build_pkgs.sh and build_test_pkgs.sh in Dart. (Closed)

Created:
4 years, 1 month ago by Bob Nystrom
Modified:
4 years, 1 month ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rewrite build_pkgs.sh and build_test_pkgs.sh in Dart. The bots need to run these before running the tests, so I'm porting them to Dart so they'll run on Windows. As a nice bonus, they're much faster now, I'm assuming because we use one warmed up VM for all of the packages. build_test_pkgs.sh on my machine went from ~12 seconds to ~4. R=jmesserly@google.com, vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/926df1e5b3086fe79789a66be309bd638c94a111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -132 lines) Patch
M .travis.yml View 1 chunk +1 line, -1 line 0 comments Download
A pkg/dev_compiler/tool/build_pkgs.dart View 1 chunk +104 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/build_pkgs.sh View 1 chunk +3 lines, -90 lines 0 comments Download
M pkg/dev_compiler/tool/build_test_pkgs.sh View 1 chunk +3 lines, -40 lines 0 comments Download
M pkg/dev_compiler/tool/test.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
4 years, 1 month ago (2016-11-12 02:20:08 UTC) #2
vsm
lgtm I think we can probably redo build_pkgs.dart and discover the right structure and just ...
4 years, 1 month ago (2016-11-14 17:39:41 UTC) #3
Jennifer Messerly
LGTM!
4 years, 1 month ago (2016-11-14 18:52:24 UTC) #4
Bob Nystrom
4 years, 1 month ago (2016-11-15 19:14:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
926df1e5b3086fe79789a66be309bd638c94a111 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698