RenderWidget: hoist synchronous IPC out of Init methods (attempt 2).

RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of Init methods.

[ Re-land of https://codereview.chromium.org/2483593002/ -- r431386 ]

RenderWidget now requires two Init phases that are always called, and always in this order:
 - InitRoutingID (formerly SetRoutingID)
 - Init (formerly DoInit).

Two distinct Init phases are needed to solve an ordering problem in RenderView.

Instead of Init being parameterized on a callback to allocate a
route ID, just do the IPC outside of Init, and pass the result in.

BUG=627852
Committed: https://crrev.com/4df698d8d1f107c9518f68c2b53213cc6c0086fa
Cr-Commit-Position: refs/heads/master@{#431627}

[ncarter (slow), 2016-11-11 16:50:16]

Description was changed from

==========
RenderWidget: hoist synchronous IPC out of Init methods (attept 2).

RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of Init
methods.

[ Re-land of https://codereview.chromium.org/2483593002/ -- r431386 ]

RenderWidget now requires two Init phases that are always called, and always in
this order:
 - InitRoutingID (formerly SetRoutingID)
 - Init (formerly DoInit).

Two distinct Init phases are needed to solve an ordering problem in RenderView.

Instead of Init being parameterized on a callback to allocate a
route ID, just do the IPC outside of Init, and pass the result in.

BUG=627852
==========

to

==========
RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of Init
methods.

[ Re-land of https://codereview.chromium.org/2483593002/ -- r431386 ]

RenderWidget now requires two Init phases that are always called, and always in
this order:
 - InitRoutingID (formerly SetRoutingID)
 - Init (formerly DoInit).

Two distinct Init phases are needed to solve an ordering problem in RenderView.

Instead of Init being parameterized on a callback to allocate a
route ID, just do the IPC outside of Init, and pass the result in.

BUG=627852
==========

[ncarter (slow), 2016-11-11 16:50:56]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 16:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 17:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 17:34:45]

Dry run: This issue passed the CQ dry run.

[ncarter (slow), 2016-11-11 18:40:32]

nick@chromium.org changed reviewers:
+ lfg@chromium.org

[ncarter (slow), 2016-11-11 18:40:33]

lfg: this is a re-land with the DCHECKs removed.

I'll hoist the routing id to the ctor in a follow-on change.

[lfg, 2016-11-11 19:04:01]

lgtm

[ncarter (slow), 2016-11-11 19:49:50]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-11-11 19:50:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:39:53]

Description was changed from

==========
RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of Init
methods.

[ Re-land of https://codereview.chromium.org/2483593002/ -- r431386 ]

RenderWidget now requires two Init phases that are always called, and always in
this order:
 - InitRoutingID (formerly SetRoutingID)
 - Init (formerly DoInit).

Two distinct Init phases are needed to solve an ordering problem in RenderView.

Instead of Init being parameterized on a callback to allocate a
route ID, just do the IPC outside of Init, and pass the result in.

BUG=627852
==========

to

==========
RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of Init
methods.

[ Re-land of https://codereview.chromium.org/2483593002/ -- r431386 ]

RenderWidget now requires two Init phases that are always called, and always in
this order:
 - InitRoutingID (formerly SetRoutingID)
 - Init (formerly DoInit).

Two distinct Init phases are needed to solve an ordering problem in RenderView.

Instead of Init being parameterized on a callback to allocate a
route ID, just do the IPC outside of Init, and pass the result in.

BUG=627852
==========

[commit-bot: I haz the power, 2016-11-11 20:39:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-11 21:00:23]

Description was changed from

==========
RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of Init
methods.

[ Re-land of https://codereview.chromium.org/2483593002/ -- r431386 ]

RenderWidget now requires two Init phases that are always called, and always in
this order:
 - InitRoutingID (formerly SetRoutingID)
 - Init (formerly DoInit).

Two distinct Init phases are needed to solve an ordering problem in RenderView.

Instead of Init being parameterized on a callback to allocate a
route ID, just do the IPC outside of Init, and pass the result in.

BUG=627852
==========

to

==========
RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of Init
methods.

[ Re-land of https://codereview.chromium.org/2483593002/ -- r431386 ]

RenderWidget now requires two Init phases that are always called, and always in
this order:
 - InitRoutingID (formerly SetRoutingID)
 - Init (formerly DoInit).

Two distinct Init phases are needed to solve an ordering problem in RenderView.

Instead of Init being parameterized on a callback to allocate a
route ID, just do the IPC outside of Init, and pass the result in.

BUG=627852

Committed: https://crrev.com/4df698d8d1f107c9518f68c2b53213cc6c0086fa
Cr-Commit-Position: refs/heads/master@{#431627}
==========

[commit-bot: I haz the power, 2016-11-11 21:00:24]

Patchset 2 (id:??) landed as
https://crrev.com/4df698d8d1f107c9518f68c2b53213cc6c0086fa
Cr-Commit-Position: refs/heads/master@{#431627}