Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2498663002: Add chrome://dino short URL to link to the internet disconnected network error interstitial (Closed)

Created:
4 years, 1 month ago by edwardjung
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome://dino short URL to link to the internet disconnected network error interstitial BUG=662661 Committed: https://crrev.com/8d968d89bd70b82af787d1a04dd915a006e59dbf Cr-Commit-Position: refs/heads/master@{#431604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/common/url_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
edwardjung
Please take a look: dbeam@: content/browser/webui/url_data_manager_backend.cc avi@: content/public/common/url_constants.h content/public/common/url_constants.cc chrome/common/url_constants.cc Thanks
4 years, 1 month ago (2016-11-11 16:23:10 UTC) #4
Avi (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-11 16:34:58 UTC) #5
Dan Beam
lgtm yesssssss
4 years, 1 month ago (2016-11-11 17:22:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498663002/1
4 years, 1 month ago (2016-11-11 18:30:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 18:35:07 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8d968d89bd70b82af787d1a04dd915a006e59dbf Cr-Commit-Position: refs/heads/master@{#431604}
4 years, 1 month ago (2016-11-11 19:00:13 UTC) #16
agable
y'all are the greatest, and this is the greatest.
4 years, 1 month ago (2016-11-11 19:17:40 UTC) #18
apacible
4 years, 1 month ago (2016-11-14 07:47:09 UTC) #19
Message was sent while issue was closed.
Thank you! :D

Powered by Google App Engine
This is Rietveld 408576698