Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2498623002: Revert of Remove mutex locks in SchemeRegistry (Closed)

Created:
4 years, 1 month ago by Charlie Harrison
Modified:
4 years, 1 month ago
CC:
blink-reviews, brucedawson, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove mutex locks in SchemeRegistry (patchset #5 id:80001 of https://codereview.chromium.org/2474303004/ ) Reason for revert: Causing build issues https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20PGO%20Builder/builds/5481 Original issue's description: > Remove mutex locks in SchemeRegistry > > This patch removes locks from the SchemeRegistry, in favor of moving all > initialization to the render thread initialization period. > > BUG=348655 > > Committed: https://crrev.com/087c8b21705dd47c9a71058bf743147324425585 > Cr-Commit-Position: refs/heads/master@{#431468} TBR=tkent@chromium.org,kinuko@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=348655 Committed: https://crrev.com/b27e567c51940289e0a989cc65f4696739d5936a Cr-Commit-Position: refs/heads/master@{#431654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -74 lines) Patch
M third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp View 22 chunks +96 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/wtf/Threading.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Charlie Harrison
Created Revert of Remove mutex locks in SchemeRegistry
4 years, 1 month ago (2016-11-11 14:13:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498623002/1
4 years, 1 month ago (2016-11-11 14:13:12 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/330145)
4 years, 1 month ago (2016-11-11 16:56:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498623002/1
4 years, 1 month ago (2016-11-11 17:54:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 21:42:07 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b27e567c51940289e0a989cc65f4696739d5936a Cr-Commit-Position: refs/heads/master@{#431654}
4 years, 1 month ago (2016-11-11 21:47:32 UTC) #11
tkent
4 years, 1 month ago (2016-11-14 01:40:00 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698