Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2816)

Unified Diff: build_overrides/build.gni

Issue 2498603002: Remove unused build override (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_overrides/build.gni
diff --git a/build_overrides/build.gni b/build_overrides/build.gni
index 122ec63f7519397420989e597076e8c32b4f545e..bc5c43ac144cd1d1ecbdedb6f96cde0a444080f2 100644
--- a/build_overrides/build.gni
+++ b/build_overrides/build.gni
@@ -2,12 +2,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# Several dependencies of Chrome require a different min sdk and/or deployment
-# target when built as stand-alone projects. If this is ever not the case, these
+# Several dependencies of Chrome require a different deployment target
kjellander_chromium 2016/11/11 12:10:18 I think you should keep "min sdk" instead?
kthelgason_chromium 2016/11/11 12:14:32 Ah, that was stupid. Fixed!
+# when built as stand-alone projects. If this is ever not the case, these
# variables can be removed.
# See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.
mac_sdk_min_build_override = "10.10"
-mac_deployment_target_build_override = "10.9"
# Variable that can be used to support multiple build scenarios, like having
# Chromium specific targets in a client project's GN file etc.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698