Revert of Fix bug where removed (but not deleted) windows are not reflected in the tree properly

Revert of Fix bug where removed (but not deleted) windows are not reflected in the tree properly (patchset #7 id:120001 of https://codereview.chromium.org/2476353002/ )

Reason for revert:
Suspected to cause SystemTrayTest.NullDefaultViewIsNotRecorded failure.

BUG=664428
Original issue's description:
> Fix bug where removed (but not deleted) windows are not reflected in the tree properly
>
> When there are windows which are removed as children of some parent, and
> they still exist, OnWindowDestroying is not called because the child window
> was never destroyed. However, OnWindowTreeChanging is called, if
> the target has an old_parent, aka the parent it is being removed from.
> OnWindowTreeChanged is called if the target has a new_parent, aka the
> parent it is being added to.
>
> This CL removes nodes on OnWindowTreeChanging and adds them back in
> OnWindowTreeChanged if necessary. Since we only want them to trigger once,
> we check to see in either callback if the window that the callback is
> being called on is the old_parent or the new_parent.
>
> BUG=648701
>
> Committed: https://crrev.com/dbef379ab2b2c8a2127d20839f77d355e9f5742e
> Cr-Commit-Position: refs/heads/master@{#431482}

TBR=sadrul@chromium.org,mhashmi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648701
Committed: https://crrev.com/fb027e734b0b86cbe440c70d6a62f63fa5c4b7b9
Cr-Commit-Position: refs/heads/master@{#431541}

[hiroshige, 2016-11-11 11:44:19]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-11-11 11:44:19]

Created Revert of Fix bug where removed (but not deleted) windows are not
reflected in the tree properly

[commit-bot: I haz the power, 2016-11-11 11:44:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 11:45:21]

Description was changed from

==========
Revert of Fix bug where removed (but not deleted) windows are not reflected in
the tree properly (patchset #7 id:120001 of
https://codereview.chromium.org/2476353002/ )

Reason for revert:
Suspected to cause SystemTrayTest.NullDefaultViewIsNotRecorded failure.

BUG=664428


Original issue's description:
> Fix bug where removed (but not deleted) windows are not reflected in the tree
properly
> 
> When there are windows which are removed as children of some parent, and
> they still exist, OnWindowDestroying is not called because the child window
> was never destroyed. However, OnWindowTreeChanging is called, if
> the target has an old_parent, aka the parent it is being removed from.
> OnWindowTreeChanged is called if the target has a new_parent, aka the
> parent it is being added to.
> 
> This CL removes nodes on OnWindowTreeChanging and adds them back in
> OnWindowTreeChanged if necessary. Since we only want them to trigger once,
> we check to see in either callback if the window that the callback is
> being called on is the old_parent or the new_parent.
> 
> BUG=648701
> 
> Committed: https://crrev.com/dbef379ab2b2c8a2127d20839f77d355e9f5742e
> Cr-Commit-Position: refs/heads/master@{#431482}

TBR=sadrul@chromium.org,mhashmi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648701
==========

to

==========
Revert of Fix bug where removed (but not deleted) windows are not reflected in
the tree properly (patchset #7 id:120001 of
https://codereview.chromium.org/2476353002/ )

Reason for revert:
Suspected to cause SystemTrayTest.NullDefaultViewIsNotRecorded failure.

BUG=664428


Original issue's description:
> Fix bug where removed (but not deleted) windows are not reflected in the tree
properly
> 
> When there are windows which are removed as children of some parent, and
> they still exist, OnWindowDestroying is not called because the child window
> was never destroyed. However, OnWindowTreeChanging is called, if
> the target has an old_parent, aka the parent it is being removed from.
> OnWindowTreeChanged is called if the target has a new_parent, aka the
> parent it is being added to.
> 
> This CL removes nodes on OnWindowTreeChanging and adds them back in
> OnWindowTreeChanged if necessary. Since we only want them to trigger once,
> we check to see in either callback if the window that the callback is
> being called on is the old_parent or the new_parent.
> 
> BUG=648701
> 
> Committed: https://crrev.com/dbef379ab2b2c8a2127d20839f77d355e9f5742e
> Cr-Commit-Position: refs/heads/master@{#431482}

TBR=sadrul@chromium.org,mhashmi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648701
==========

[commit-bot: I haz the power, 2016-11-11 11:45:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-11 11:47:59]

Description was changed from

==========
Revert of Fix bug where removed (but not deleted) windows are not reflected in
the tree properly (patchset #7 id:120001 of
https://codereview.chromium.org/2476353002/ )

Reason for revert:
Suspected to cause SystemTrayTest.NullDefaultViewIsNotRecorded failure.

BUG=664428


Original issue's description:
> Fix bug where removed (but not deleted) windows are not reflected in the tree
properly
> 
> When there are windows which are removed as children of some parent, and
> they still exist, OnWindowDestroying is not called because the child window
> was never destroyed. However, OnWindowTreeChanging is called, if
> the target has an old_parent, aka the parent it is being removed from.
> OnWindowTreeChanged is called if the target has a new_parent, aka the
> parent it is being added to.
> 
> This CL removes nodes on OnWindowTreeChanging and adds them back in
> OnWindowTreeChanged if necessary. Since we only want them to trigger once,
> we check to see in either callback if the window that the callback is
> being called on is the old_parent or the new_parent.
> 
> BUG=648701
> 
> Committed: https://crrev.com/dbef379ab2b2c8a2127d20839f77d355e9f5742e
> Cr-Commit-Position: refs/heads/master@{#431482}

TBR=sadrul@chromium.org,mhashmi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648701
==========

to

==========
Revert of Fix bug where removed (but not deleted) windows are not reflected in
the tree properly (patchset #7 id:120001 of
https://codereview.chromium.org/2476353002/ )

Reason for revert:
Suspected to cause SystemTrayTest.NullDefaultViewIsNotRecorded failure.

BUG=664428

Original issue's description:
> Fix bug where removed (but not deleted) windows are not reflected in the tree
properly
>
> When there are windows which are removed as children of some parent, and
> they still exist, OnWindowDestroying is not called because the child window
> was never destroyed. However, OnWindowTreeChanging is called, if
> the target has an old_parent, aka the parent it is being removed from.
> OnWindowTreeChanged is called if the target has a new_parent, aka the
> parent it is being added to.
>
> This CL removes nodes on OnWindowTreeChanging and adds them back in
> OnWindowTreeChanged if necessary. Since we only want them to trigger once,
> we check to see in either callback if the window that the callback is
> being called on is the old_parent or the new_parent.
>
> BUG=648701
>
> Committed: https://crrev.com/dbef379ab2b2c8a2127d20839f77d355e9f5742e
> Cr-Commit-Position: refs/heads/master@{#431482}

TBR=sadrul@chromium.org,mhashmi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648701

Committed: https://crrev.com/fb027e734b0b86cbe440c70d6a62f63fa5c4b7b9
Cr-Commit-Position: refs/heads/master@{#431541}
==========

[commit-bot: I haz the power, 2016-11-11 11:48:00]

Patchset 1 (id:??) landed as
https://crrev.com/fb027e734b0b86cbe440c70d6a62f63fa5c4b7b9
Cr-Commit-Position: refs/heads/master@{#431541}

[sadrul, 2016-11-11 13:44:45]

On 2016/11/11 11:48:00, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/fb027e734b0b86cbe440c70d6a62f63fa5c4b7b9
> Cr-Commit-Position: refs/heads/master@{#431541}

Did the revert fix the failure? (This cl should not affect those tests)

[hiroshige, 2016-11-12 05:06:56]

On 2016/11/11 13:44:45, sadrul wrote:
> On 2016/11/11 11:48:00, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/fb027e734b0b86cbe440c70d6a62f63fa5c4b7b9
> > Cr-Commit-Position: refs/heads/master@{#431541}
> 
> Did the revert fix the failure? (This cl should not affect those tests)

Yes, this revert looks to fix the failure.

Before revert:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...

After revert:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui...
No failure after this.