Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: test/cctest/test-weakmaps.cc

Issue 2498583002: [heap] Minor MC: Add marking (Closed)
Patch Set: Move to concurrent uncomitting of marking deque Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | test/unittests/heap/gc-idle-time-handler-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 // Force compacting garbage collection. The subsequent collections are used 242 // Force compacting garbage collection. The subsequent collections are used
243 // to verify that key references were actually updated. 243 // to verify that key references were actually updated.
244 CHECK(FLAG_always_compact); 244 CHECK(FLAG_always_compact);
245 CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask); 245 CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask);
246 CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask); 246 CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask);
247 CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask); 247 CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask);
248 } 248 }
249 249
250 250
251 TEST(Regress399527) { 251 TEST(Regress399527) {
252 if (!FLAG_incremental_marking) return;
252 CcTest::InitializeVM(); 253 CcTest::InitializeVM();
253 v8::HandleScope scope(CcTest::isolate()); 254 v8::HandleScope scope(CcTest::isolate());
254 Isolate* isolate = CcTest::i_isolate(); 255 Isolate* isolate = CcTest::i_isolate();
255 Heap* heap = isolate->heap(); 256 Heap* heap = isolate->heap();
256 { 257 {
257 HandleScope scope(isolate); 258 HandleScope scope(isolate);
258 AllocateJSWeakMap(isolate); 259 AllocateJSWeakMap(isolate);
259 heap::SimulateIncrementalMarking(heap); 260 heap::SimulateIncrementalMarking(heap);
260 } 261 }
261 // The weak map is marked black here but leaving the handle scope will make 262 // The weak map is marked black here but leaving the handle scope will make
262 // the object unreachable. Aborting incremental marking will clear all the 263 // the object unreachable. Aborting incremental marking will clear all the
263 // marking bits which makes the weak map garbage. 264 // marking bits which makes the weak map garbage.
264 CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask); 265 CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask);
265 } 266 }
OLDNEW
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | test/unittests/heap/gc-idle-time-handler-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698