Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 2498573002: Add a return when StopWorker is called after service worker is stopped (Closed)

Created:
4 years, 1 month ago by shimazu
Modified:
4 years, 1 month ago
Reviewers:
falken, nhiroki
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, tzik, jsbell+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a return when StopWorker is called after service worker is stopped Currently StopWorker might be crashed when stop is requested after the worker's context is destoryed. This patch adds a check condition if the worker is already stopped. BUG=664014 Committed: https://crrev.com/a32c1633d7f194771bb32c38c9ff100d34e49642 Cr-Commit-Position: refs/heads/master@{#431543}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/service_worker/embedded_worker_instance_client_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_instance_client_impl.cc View 2 chunks +2 lines, -1 line 2 comments Download

Messages

Total messages: 13 (7 generated)
shimazu
ptal
4 years, 1 month ago (2016-11-11 10:25:37 UTC) #4
falken
lgtm
4 years, 1 month ago (2016-11-11 10:27:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498573002/1
4 years, 1 month ago (2016-11-11 10:28:39 UTC) #8
nhiroki
https://codereview.chromium.org/2498573002/diff/1/content/renderer/service_worker/embedded_worker_instance_client_impl.cc File content/renderer/service_worker/embedded_worker_instance_client_impl.cc (right): https://codereview.chromium.org/2498573002/diff/1/content/renderer/service_worker/embedded_worker_instance_client_impl.cc#newcode68 content/renderer/service_worker/embedded_worker_instance_client_impl.cc:68: wrapper_ = wrapper.get(); DCHECK(!wrapper_); https://codereview.chromium.org/2498573002/diff/1/content/renderer/service_worker/embedded_worker_instance_client_impl.cc#newcode92 content/renderer/service_worker/embedded_worker_instance_client_impl.cc:92: temporal_self_(std::unique_ptr<EmbeddedWorkerInstanceClientImpl>(this)) { How ...
4 years, 1 month ago (2016-11-11 11:24:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 11:52:11 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 11:57:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a32c1633d7f194771bb32c38c9ff100d34e49642
Cr-Commit-Position: refs/heads/master@{#431543}

Powered by Google App Engine
This is Rietveld 408576698