Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2498563002: [cleanup] Replace ToBooleanICStub::Types with ToBooleanHints (Closed)

Created:
4 years, 1 month ago by Jakob Kummerow
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Replace ToBooleanICStub::Types with ToBooleanHints And decouple hydrogen-instructions.h from code-stubs.h. This avoids all of Crankshaft being recompiled when code-stub-assembler.h changes. Committed: https://crrev.com/fc97c638fabfe75e24c173a90f5ca2732578fcb0 Cr-Commit-Position: refs/heads/master@{#40912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -495 lines) Patch
M src/code-stubs.h View 6 chunks +11 lines, -59 lines 0 comments Download
M src/code-stubs.cc View 4 chunks +29 lines, -118 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/type-hint-analyzer.cc View 1 chunk +1 line, -15 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 4 chunks +15 lines, -16 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.h View 1 chunk +3 lines, -22 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 7 chunks +38 lines, -16 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 4 chunks +9 lines, -10 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 3 chunks +23 lines, -9 lines 0 comments Download
M src/crankshaft/hydrogen-osr.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 5 chunks +15 lines, -16 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M src/crankshaft/lithium.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.h View 1 chunk +3 lines, -18 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 6 chunks +34 lines, -16 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.h View 1 chunk +3 lines, -18 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 6 chunks +34 lines, -16 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.h View 1 chunk +3 lines, -15 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 5 chunks +31 lines, -16 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.h View 1 chunk +3 lines, -15 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 5 chunks +32 lines, -16 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 5 chunks +15 lines, -16 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 5 chunks +15 lines, -16 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M src/type-hints.h View 2 chunks +20 lines, -1 line 0 comments Download
M src/type-hints.cc View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL.
4 years, 1 month ago (2016-11-11 10:15:44 UTC) #2
Benedikt Meurer
LGTM.
4 years, 1 month ago (2016-11-11 10:16:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498563002/1
4 years, 1 month ago (2016-11-11 10:20:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 10:50:16 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc97c638fabfe75e24c173a90f5ca2732578fcb0
Cr-Commit-Position: refs/heads/master@{#40912}

Powered by Google App Engine
This is Rietveld 408576698