Add support for Junit tests in platform mode.

Add support for Junit tests in platform mode.

Adding support for Junit tests in platform mode. Added new test env
for running tests on local machine.

Committed: https://crrev.com/291bc84f19c0e49f1d5d5a7992bf422a5f796ffd
Cr-Commit-Position: refs/heads/master@{#431711}

[mikecase (-- gone --), 2016-11-11 22:16:23]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, rnephew@chromium.org

[mikecase (-- gone --), 2016-11-11 22:16:24]

https://codereview.chromium.org/2498553004/diff/1/build/android/pylib/junit/t...
File build/android/pylib/junit/test_runner.py (left):

https://codereview.chromium.org/2498553004/diff/1/build/android/pylib/junit/t...
build/android/pylib/junit/test_runner.py:43: if self._sdk_version:
I have no idea what this arg was used for. But it doesnt seem to have been used
for years.

[jbudorick, 2016-11-11 22:29:38]

Pretty straightforward transition, it seems. lgtm w/ nit+q

https://codereview.chromium.org/2498553004/diff/1/build/android/pylib/local/m...
File build/android/pylib/local/machine/local_machine_junit_test_run.py (right):

https://codereview.chromium.org/2498553004/diff/1/build/android/pylib/local/m...
build/android/pylib/local/machine/local_machine_junit_test_run.py:17:
test_run.TestRun):
nit: this shouldn't be on its own line.

https://codereview.chromium.org/2498553004/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/machine/local_machine_junit_test_run.py (right):

https://codereview.chromium.org/2498553004/diff/20001/build/android/pylib/loc...
build/android/pylib/local/machine/local_machine_junit_test_run.py:67:
cmd_helper.RunCmd(command)
Should this be doing something with the exit code?

[mikecase (-- gone --), 2016-11-11 22:51:36]

https://codereview.chromium.org/2498553004/diff/1/build/android/pylib/local/m...
File build/android/pylib/local/machine/local_machine_junit_test_run.py (right):

https://codereview.chromium.org/2498553004/diff/1/build/android/pylib/local/m...
build/android/pylib/local/machine/local_machine_junit_test_run.py:17:
test_run.TestRun):
On 2016/11/11 at 22:29:38, jbudorick wrote:
> nit: this shouldn't be on its own line.

Done

https://codereview.chromium.org/2498553004/diff/20001/build/android/pylib/loc...
File build/android/pylib/local/machine/local_machine_junit_test_run.py (right):

https://codereview.chromium.org/2498553004/diff/20001/build/android/pylib/loc...
build/android/pylib/local/machine/local_machine_junit_test_run.py:67:
cmd_helper.RunCmd(command)
On 2016/11/11 at 22:29:38, jbudorick wrote:
> Should this be doing something with the exit code?

So, non-platform-mode does return the exit code, which ends up being returned by
test_runner.py. This cmd call will return 1 is any test fails and 0 other wise.

https://cs.chromium.org/chromium/src/testing/android/junit/java/src/org/chrom...


However, the platform-mode parts in the test_runner.py have their own way of
generating an exit code. They look at the BaseTestResults objects and return an
exit_code based on whether there are any failures.

https://cs.chromium.org/chromium/src/build/android/test_runner.py?q=test_runn...

I looked through it a bit, and I think there wont be any (or much, idk what
happens if something crashes) difference in the exit code returned

[mikecase (-- gone --), 2016-11-11 22:57:41]

The CQ bit was checked by mikecase@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 22:58:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 23:59:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 23:59:26]

Dry run: This issue passed the CQ dry run.

[mikecase (-- gone --), 2016-11-12 00:31:50]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-11-12 00:32:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:38:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-12 00:42:04]

Description was changed from

==========
Add support for Junit tests in platform mode.

Adding support for Junit tests in platform mode. Added new test env
for running tests on local machine.
==========

to

==========
Add support for Junit tests in platform mode.

Adding support for Junit tests in platform mode. Added new test env
for running tests on local machine.

Committed: https://crrev.com/291bc84f19c0e49f1d5d5a7992bf422a5f796ffd
Cr-Commit-Position: refs/heads/master@{#431711}
==========

[commit-bot: I haz the power, 2016-11-12 00:42:04]

Patchset 2 (id:??) landed as
https://crrev.com/291bc84f19c0e49f1d5d5a7992bf422a5f796ffd
Cr-Commit-Position: refs/heads/master@{#431711}