Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2498533002: Merged: [debug] Disable debug events if JS execution is disallowed (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.5
Project:
v8
Visibility:
Public.

Description

Merged: [debug] Disable debug events if JS execution is disallowed Revision: 8f22fcec24abdece924190f413005387b8ced6fc BUG=chromium:662674 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=yangguo@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/be4f2bb0101205aeb37f911bf2c71614839e6f39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/debug/debug.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/debugger/debug/regress/regress-662674.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jgruber
4 years, 1 month ago (2016-11-11 06:45:30 UTC) #1
jgruber
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 1 month ago (2016-11-11 06:45:32 UTC) #2
Yang
On 2016/11/11 06:45:32, jgruber wrote: > NOTE: This script will no longer automatically update include/v8-version.h ...
4 years, 1 month ago (2016-11-11 06:45:55 UTC) #3
jgruber
4 years, 1 month ago (2016-11-11 06:49:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be4f2bb0101205aeb37f911bf2c71614839e6f39.

Powered by Google App Engine
This is Rietveld 408576698