Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2498503002: Http Bad: Add icons to the http warning message (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index d7e7cfcf3e2bb6bb3f98cf20f8441a302e74f6fc..3de9157f9a094776a3d5bc62002a367986f4f86a 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -183,6 +183,21 @@ bool IsCreditCardExpirationType(ServerFieldType type) {
type == CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR;
}
+// Create http bad warning message at the top of autofill popup list showing
+// "Payment not secure" when users are on http sites or broken https sites.
+Suggestion CreateHttpWarningMessageSuggestionItem(const GURL& source_url) {
+ Suggestion cc_field_http_warning_suggestion(
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE));
+ cc_field_http_warning_suggestion.frontend_id =
+ POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
+ cc_field_http_warning_suggestion.icon =
+ (source_url.is_valid() && source_url.SchemeIs("http"))
+ ? base::ASCIIToUTF16("httpWarning")
+ : base::ASCIIToUTF16("httpsInvalid");
+
+ return cc_field_http_warning_suggestion;
+}
+
} // namespace
AutofillManager::AutofillManager(
@@ -576,12 +591,9 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
// On top of the explanation message, first show a "Payment not secure"
// message.
if (IsCreditCardAutofillHttpWarningEnabled()) {
- Suggestion cc_field_http_warning_suggestion(l10n_util::GetStringUTF16(
- IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE));
- cc_field_http_warning_suggestion.frontend_id =
- POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
suggestions.insert(suggestions.begin(),
- cc_field_http_warning_suggestion);
+ CreateHttpWarningMessageSuggestionItem(
+ form_structure->source_url()));
}
} else {
bool section_is_autofilled =

Powered by Google App Engine
This is Rietveld 408576698