Http Bad: Add icons to the http warning message

components/autofill/core/browser/autofill_manager.cc

Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index d7e7cfcf3e2bb6bb3f98cf20f8441a302e74f6fc..ac658a38e93ca2437c3a61b0a6fe0cfed8fcc92a 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -183,6 +183,24 @@ bool IsCreditCardExpirationType(ServerFieldType type) {
          type == CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR;
 }
 
+// Create http bad warning message at the top of autofill popup list showing
+// "Payment not secure" when users are on http sites or broken https sites.
+Suggestion CreateHttpWarningMessageSuggestionItem(const GURL& source_url) {
+  std::string icon_str;
+
+  // Show http warning icon for http sites.
+  if (source_url.is_valid() && source_url.SchemeIs("http")) {
+    icon_str = "httpWarning";
+  } else {
+    // Show https_invalid icon for broken https sites.
+    icon_str = "httpsInvalid";
+  }
+
+  return Suggestion(
+      l10n_util::GetStringUTF8(IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE),

[Evan Stade, 2016/11/28 16:12:02]

nit: the documentation for Suggestion says this constructor is for tests only.
Can you construct it in a way more similar to the code you deleted further down?

[lshang, 2016/11/29 10:07:35]

Done.

+      std::string(), icon_str, POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE);
+}
+
 }  // namespace
 
 AutofillManager::AutofillManager(
@@ -576,12 +594,9 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
         // On top of the explanation message, first show a "Payment not secure"
         // message.
         if (IsCreditCardAutofillHttpWarningEnabled()) {
-          Suggestion cc_field_http_warning_suggestion(l10n_util::GetStringUTF16(
-              IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE));
-          cc_field_http_warning_suggestion.frontend_id =
-              POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
           suggestions.insert(suggestions.begin(),
-                             cc_field_http_warning_suggestion);
+                             CreateHttpWarningMessageSuggestionItem(
+                                 form_structure->source_url()));
         }
       } else {
         bool section_is_autofilled =