components/resources/autofill_scaled_resources.grdp - Issue 2498503002: Http Bad: Add icons to the http warning message

Side by Side Diff: components/resources/autofill_scaled_resources.grdp

Issue 2498503002: Http Bad: Add icons to the http warning message (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« components/password_manager/core/browser/password_autofill_manager.cc ('K') | « components/password_manager/core/browser/password_autofill_manager.cc ('k') | components/resources/default_100_percent/autofill/omnibox_https_invalid.png » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <grit-part>	2 <grit-part>

3 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_AMEX" file="autofi ll/amex.png" />	3 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_AMEX" file="autofi ll/amex.png" />

4 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_DISCOVER" file="au tofill/discover.png" />	4 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_DISCOVER" file="au tofill/discover.png" />

5 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_GENERIC" file="aut ofill/cc-generic.png" />	5 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_GENERIC" file="aut ofill/cc-generic.png" />

6 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_MASTERCARD" file=" autofill/mastercard.png" />	6 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_MASTERCARD" file=" autofill/mastercard.png" />

7 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_VISA" file="autofi ll/visa.png" />	7 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_VISA" file="autofi ll/visa.png" />

	8 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_HTTP_WARNING" file="a utofill/omnibox_info.png" />
	Mathieu 2016/11/16 04:53:09 why does it have "omnibox" in the name? why does it have "omnibox" in the name? lshang 2016/11/16 05:16:14 Cause it is the same icon used in the omnibox to i Show quoted text On 2016/11/16 04:53:09, Mathieu Perreault wrote: > why does it have "omnibox" in the name? Cause it is the same icon used in the omnibox to indicate security connections. On desktops these icons are in the format of vector icons, so I copied the png format icons from Android resources to use for autofill. I'm happy to change for another name for them:-)
	9 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_HTTPS_INVALID_WARNING " file="autofill/omnibox_https_invalid.png" />

8	10

9 <!-- These are not used on desktop, only Android, so use a placeholder file.	11 <!-- These are not used on desktop, only Android, so use a placeholder file.

10 TODO(rouslan): Remove non-keyboard-accessory icon when keyboard	12 TODO(rouslan): Remove non-keyboard-accessory icon when keyboard

11 accessory becomes default on Android. -->	13 accessory becomes default on Android. -->

12 <if expr="is_android">	14 <if expr="is_android">

13 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_SCAN_NEW" file=" autofill/cc-generic.png" />	15 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_SCAN_NEW" file=" autofill/cc-generic.png" />

14 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_SCAN_NEW_KEYBOAR D_ACCESSORY" file="autofill/cc-generic.png" />	16 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_CC_SCAN_NEW_KEYBOAR D_ACCESSORY" file="autofill/cc-generic.png" />

15 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_SETTINGS" file="aut ofill/cc-generic.png" />	17 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_SETTINGS" file="aut ofill/cc-generic.png" />

16 </if>	18 </if>

17	19

(...skipping 13 matching lines...) Expand all Loading...
31 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT" file="au tofill/credit_card_cvc_hint.png" />	33 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT" file="au tofill/credit_card_cvc_hint.png" />

32 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT_AMEX" fil e="autofill/credit_card_cvc_hint_amex.png" />	34 <structure type="chrome_scaled_image" name="IDR_CREDIT_CARD_CVC_HINT_AMEX" fil e="autofill/credit_card_cvc_hint_amex.png" />

33 <if expr="is_ios or is_android">	35 <if expr="is_ios or is_android">

34 <structure type="chrome_scaled_image" name="IDR_INFOBAR_AUTOFILL_CC" file="a utofill/infobar_autofill_cc.png" />	36 <structure type="chrome_scaled_image" name="IDR_INFOBAR_AUTOFILL_CC" file="a utofill/infobar_autofill_cc.png" />

35 </if>	37 </if>

36 <if expr="is_macosx or is_ios">	38 <if expr="is_macosx or is_ios">

37 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON" file= "autofill/autofill_tooltip_icon.png" />	39 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON" file= "autofill/autofill_tooltip_icon.png" />

38 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON_H" fil e="autofill/autofill_tooltip_icon_hover.png" />	40 <structure type="chrome_scaled_image" name="IDR_AUTOFILL_TOOLTIP_ICON_H" fil e="autofill/autofill_tooltip_icon_hover.png" />

39 </if>	41 </if>

40 </grit-part>	42 </grit-part>

OLD	NEW