Http Bad: Add icons to the http warning message

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 558 matching lines @@
         // Autofill is disabled for a website.
         Suggestion warning_suggestion(l10n_util::GetStringUTF16(
             IDS_AUTOFILL_WARNING_INSECURE_CONNECTION));
         warning_suggestion.frontend_id =
             POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE;
         suggestions.assign(1, warning_suggestion);
 
         // On top of the explanation message, first show a "Payment not secure"
         // message.
         if (IsCreditCardAutofillHttpWarningEnabled()) {
-          Suggestion cc_field_http_warning_suggestion(l10n_util::GetStringUTF16(
-              IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE));
-          cc_field_http_warning_suggestion.frontend_id =
-              POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
+          std::string icon_str;

[Mathieu, 2016/11/16 04:53:09]

I think there is enough here to create an anonymous namespace function that
returns a Suggestion. 

[lshang, 2016/11/16 10:33:08]

Done.

+
+          // Show http info icon for http sites.
+          if (form_structure->source_url().is_valid() &&
+              form_structure->source_url().SchemeIs("http")) {
+            icon_str = "http";
+          } else {
+            // Show https_invalid icon for broken https sites.
+            icon_str = "httpsInvalid";
+          }
+
+          Suggestion cc_field_http_warning_suggestion(
+              l10n_util::GetStringUTF8(
+                  IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE),
+              "", icon_str, POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE);
           suggestions.insert(suggestions.begin(),
                              cc_field_http_warning_suggestion);
         }
       } else {
         bool section_is_autofilled =
             SectionIsAutofilled(*form_structure, form,
                                 autofill_field->section());
         if (section_is_autofilled) {
           // If the relevant section is auto-filled and the renderer is querying
           // for suggestions, then the user is editing the value of a field.
@@ skipping 1511 matching lines @@
     if (i > 0)
       fputs("Next oldest form:\n", file);
   }
   fputs("\n", file);
 
   fclose(file);
 }
 #endif  // ENABLE_FORM_DEBUG_DUMP
 
 }  // namespace autofill