Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2498483002: [ios] Removed goBack/goForward from CRWSessionController. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed goBack/goForward from CRWSessionController. These methods are unused and CRWSessionController should be folded into NavigationManager. BUG=661316 Committed: https://crrev.com/54cd9dad1e908f83de618794b8ade832fa5db58f Cr-Commit-Position: refs/heads/master@{#432593}

Patch Set 1 #

Patch Set 2 : Merged with origin/master #

Patch Set 3 : Merged with origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web/navigation/crw_session_controller_unittest.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-15 00:11:26 UTC) #3
kkhorimoto
lgtm
4 years, 1 month ago (2016-11-16 02:31:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498483002/20001
4 years, 1 month ago (2016-11-16 19:30:47 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 19:37:34 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 19:53:49 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54cd9dad1e908f83de618794b8ade832fa5db58f
Cr-Commit-Position: refs/heads/master@{#432593}

Powered by Google App Engine
This is Rietveld 408576698