Fix a bug where deletions weren't updating the raw Kind index.

impl/memory/datastore_index.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package memory
 
 import (
         "bytes"
         "fmt"
         "sort"
@@ skipping 27 matching lines @@
                 ret = append(ret, &ds.IndexDefinition{Kind: kind, SortBy: []ds.IndexColumn{{Property: name}}})
                 ret = append(ret, &ds.IndexDefinition{Kind: kind, SortBy: []ds.IndexColumn{{Property: name, Descending: true}}})
         }
         if serializationDeterministic {
                 sort.Sort(ret)
         }
         return ret
 }
 
 func indexEntriesWithBuiltins(k *ds.Key, pm ds.PropertyMap, complexIdxs []*ds.IndexDefinition) memStore {
-        sip := serialize.PropertyMapPartially(k, pm)
+        var sip serialize.SerializedPmap
+        if pm != nil {
+                sip = serialize.PropertyMapPartially(k, pm)
+        }
         return indexEntries(sip, k.Namespace(), append(defaultIndexes(k.Kind(), pm), complexIdxs...))
 }
 
 // indexRowGen contains enough information to generate all of the index rows which
 // correspond with a propertyList and a ds.IndexDefinition.
 type indexRowGen struct {
         propVec   []serialize.SerializedPslice
         decending []bool
 }
 
@@ skipping 190 matching lines @@
 
                                 mergeIndexes(ns, store,
                                         newMemStore(),
                                         indexEntries(sip, ns, normalized))
                                 return true
                         })
                 }
         }
 }
 
 func updateIndexes(store memStore, key *ds.Key, oldEnt, newEnt ds.PropertyMap) {

[iannucci, 2016/11/12 00:05:47]

add comment mentioning that nil has special meaning vs just an empty property
map.

         // load all current complex query index definitions.
-        compIdx := []*ds.IndexDefinition{}
+        var compIdx []*ds.IndexDefinition
         walkCompIdxs(store.Snapshot(), nil, func(i *ds.IndexDefinition) bool {
                 compIdx = append(compIdx, i)
                 return true
         })
 
         mergeIndexes(key.Namespace(), store,
                 indexEntriesWithBuiltins(key, oldEnt, compIdx),
                 indexEntriesWithBuiltins(key, newEnt, compIdx))
 }