Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: content/common/swapped_out_messages.cc

Issue 2498463002: RenderWidget/RenderView: encapsulate ViewHostMsg_Show, etc, in a callback (Closed)
Patch Set: Remove RenderWidgetFullscreen Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/swapped_out_messages.cc
diff --git a/content/common/swapped_out_messages.cc b/content/common/swapped_out_messages.cc
index 776b8ee5c09b5af2f0eae23c78856f75da394404..3a47eda67ecc770ab401f55d444296535f94536c 100644
--- a/content/common/swapped_out_messages.cc
+++ b/content/common/swapped_out_messages.cc
@@ -27,6 +27,9 @@ bool SwappedOutMessages::CanSendWhileSwappedOut(const IPC::Message* msg) {
case ViewHostMsg_Focus::ID:
// Handled by RenderViewHost.
case ViewHostMsg_ClosePage_ACK::ID:
+ case ViewHostMsg_ShowFullscreenWidget::ID:
+ case ViewHostMsg_ShowView::ID:
+ case ViewHostMsg_ShowWidget::ID:
case ViewHostMsg_SwapCompositorFrame::ID:
// Handled by SharedWorkerMessageFilter.
case ViewHostMsg_DocumentDetached::ID:
@@ -68,12 +71,6 @@ bool SwappedOutMessages::CanHandleWhileSwappedOut(
// Note that synchronous messages that are not handled will receive an
// error reply instead, to avoid leaving the renderer in a stuck state.
switch (msg.type()) {
- // Sends an ACK.
- case ViewHostMsg_ShowView::ID:
- // Sends an ACK.
- case ViewHostMsg_ShowWidget::ID:
- // Sends an ACK.
- case ViewHostMsg_ShowFullscreenWidget::ID:
// Updates the previous navigation entry.
case ViewHostMsg_UpdateState::ID:
// Sends an ACK.
« no previous file with comments | « android_webview/renderer/aw_content_renderer_client.cc ('k') | content/public/renderer/content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698