Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: content/renderer/render_widget_fullscreen_pepper.h

Issue 2498463002: RenderWidget/RenderView: encapsulate ViewHostMsg_Show, etc, in a callback (Closed)
Patch Set: Fixes. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget_fullscreen_pepper.h
diff --git a/content/renderer/render_widget_fullscreen_pepper.h b/content/renderer/render_widget_fullscreen_pepper.h
index 661945115c8f8ceb6a68a846f6f0948bfdf4caec..6bb4ef849910aa6732a7eda5436c0a6fe40894b2 100644
--- a/content/renderer/render_widget_fullscreen_pepper.h
+++ b/content/renderer/render_widget_fullscreen_pepper.h
@@ -12,7 +12,7 @@
#include "base/macros.h"
#include "content/renderer/mouse_lock_dispatcher.h"
#include "content/renderer/pepper/fullscreen_container.h"
-#include "content/renderer/render_widget_fullscreen.h"
+#include "content/renderer/render_widget.h"
#include "third_party/WebKit/public/web/WebWidget.h"
#include "url/gurl.h"
@@ -21,17 +21,18 @@ class WebLayer;
}
namespace content {
+class CompositorDependencies;
class PepperPluginInstanceImpl;
// A RenderWidget that hosts a fullscreen pepper plugin. This provides a
// FullscreenContainer that the plugin instance can callback into to e.g.
// invalidate rects.
-class RenderWidgetFullscreenPepper : public RenderWidgetFullscreen,
+class RenderWidgetFullscreenPepper : public RenderWidget,
public FullscreenContainer {
public:
static RenderWidgetFullscreenPepper* Create(
int32_t routing_id,
- int32_t opener_id,
+ const RenderWidget::ShowCallback& show_callback,
CompositorDependencies* compositor_deps,
PepperPluginInstanceImpl* plugin,
const GURL& active_url,
@@ -69,9 +70,6 @@ class RenderWidgetFullscreenPepper : public RenderWidgetFullscreen,
void Close() override;
void OnResize(const ResizeParams& params) override;
- // RenderWidgetFullscreen API.
- blink::WebWidget* CreateWebWidget() override;
-
// RenderWidget overrides.
GURL GetURLForGraphicsContext3D() override;
void OnDeviceScaleFactorChanged() override;

Powered by Google App Engine
This is Rietveld 408576698