Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2498423004: net::SimplifyUrlForRequest fast path for URLs without {user,pass,ref} parts. (Closed)

Created:
4 years, 1 month ago by Charlie Harrison
Modified:
4 years ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net::SimplifyUrlForRequest fast path for URLs without {user,pass,ref} parts. This function uses GURL::ReplaceComponents which triggers canonicalization of the new URL. For the normal case where urls do not have usernames, passwords, or ref parts, we can just return the original URL. ReplaceComponents takes around 13% of the time spent in HttpCache::Transaction::Start with a SimpleCache backend on Linux, but this method is used in a few different places. BUG=664174 Committed: https://crrev.com/16060210ca945bcd601e380617d75f916a084932 Cr-Commit-Position: refs/heads/master@{#434756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M net/base/url_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Charlie Harrison
gavinp@ ptal?
4 years, 1 month ago (2016-11-15 20:51:57 UTC) #4
gavinp
lgtm. profiler for the win!
4 years ago (2016-11-28 17:51:45 UTC) #7
Charlie Harrison
Thanks Gavin!
4 years ago (2016-11-28 17:52:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498423004/1
4 years ago (2016-11-28 17:52:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 22:53:20 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 22:55:26 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16060210ca945bcd601e380617d75f916a084932
Cr-Commit-Position: refs/heads/master@{#434756}

Powered by Google App Engine
This is Rietveld 408576698