Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2498403002: Compute WorldImpact in NativeEnqueuer. (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -55 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 15 chunks +39 lines, -51 lines 2 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/2498403002/diff/20001/pkg/compiler/lib/src/native/enqueue.dart File pkg/compiler/lib/src/native/enqueue.dart (left): https://codereview.chromium.org/2498403002/diff/20001/pkg/compiler/lib/src/native/enqueue.dart#oldcode88 pkg/compiler/lib/src/native/enqueue.dart:88: new Map<ClassElement, Set<ClassElement>>(); Unused https://codereview.chromium.org/2498403002/diff/20001/pkg/compiler/lib/src/native/enqueue.dart#oldcode94 pkg/compiler/lib/src/native/enqueue.dart:94: final Set matchedTypeConstraints ...
4 years, 1 month ago (2016-11-15 15:21:56 UTC) #2
Harry Terkelsen
lgtm
4 years, 1 month ago (2016-11-15 17:01:07 UTC) #3
Johnni Winther
4 years, 1 month ago (2016-11-16 10:21:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
12e2244310e387315e437b49e09865a43da17dec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698