Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 2498383002: cc: Implement tiling iterator based on pyramid sequence.

Created:
4 years, 1 month ago by prashant.n
Modified:
4 years, 1 month ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, alemate+watch_chromium.org, creis+watch_chromium.org, jam, nasko+codewatch_chromium.org, achuith+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, cc-bugs_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Implement tiling iterator based on pyramid sequence. This patch implements pyramid sequence for getting tile indices from closer to farther or farther to closer fashion. The pyramid sequence iterates level by level, i.e. inner level to outer level and vice versa. This is used to implement SpiralDifferenceIterator and ReverseSpiralDifferenceIterator. The pyramid sequence takes width and height of the tile into consideration, giving better order of tiles over previous version. The tiling iterator can be specified to use pyramid sequence by using "--tiling-iterator=pyramid-sequence". By default tiling iterator is spiral iterator. BUG=613695 TESTS=PyramidSequenceTest.* CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2480 lines, -167 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/base/index_rect.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/base/index_rect.cc View 2 chunks +8 lines, -0 lines 0 comments Download
A cc/base/pyramid_sequence.h View 1 chunk +703 lines, -0 lines 0 comments Download
A cc/base/pyramid_sequence.cc View 1 chunk +1218 lines, -0 lines 0 comments Download
A + cc/base/pyramid_sequence_unittest.cc View 28 chunks +133 lines, -108 lines 0 comments Download
M cc/base/reverse_spiral_iterator.h View 1 chunk +5 lines, -1 line 0 comments Download
M cc/base/reverse_spiral_iterator.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M cc/base/spiral_iterator.h View 1 chunk +5 lines, -1 line 0 comments Download
M cc/base/spiral_iterator.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M cc/base/spiral_iterator_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/base/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/base/tiling_data.h View 5 chunks +33 lines, -2 lines 0 comments Download
M cc/base/tiling_data.cc View 6 chunks +190 lines, -42 lines 0 comments Download
M cc/tiles/tiling_set_eviction_queue.h View 6 chunks +42 lines, -0 lines 0 comments Download
M cc/tiles/tiling_set_eviction_queue.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M cc/tiles/tiling_set_raster_queue_all.h View 7 chunks +47 lines, -0 lines 0 comments Download
M cc/tiles/tiling_set_raster_queue_all.cc View 4 chunks +20 lines, -3 lines 0 comments Download
M cc/tiles/tiling_set_raster_queue_required.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/tiles/tiling_set_raster_queue_required.cc View 1 chunk +15 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
prashant.n
ptal.
4 years, 1 month ago (2016-11-15 13:59:29 UTC) #3
prashant.n
4 years, 1 month ago (2016-11-22 06:27:02 UTC) #4
I'll try to make this faster than current spiral iterator.

Powered by Google App Engine
This is Rietveld 408576698