Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2498353002: [ast] Change printing of {Variable::maybe_assigned}. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Change printing of {Variable::maybe_assigned}. This reverses the printing scheme for the flag in question to make it print the "positive" analysis results (i.e. variable never assigned) instead of the "negative" results (i.e. variable maybe assigned). This helps to spot false-positives which are much more dangerous in practice compared to missed optimization opportunities. R=neis@chromium.org Committed: https://crrev.com/1a36eaea4b6d788fef2b3073d327a7fc33849acd Cr-Commit-Position: refs/heads/master@{#40993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ast/scopes.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-15 13:14:11 UTC) #1
neis
lgtm
4 years, 1 month ago (2016-11-15 13:15:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498353002/1
4 years, 1 month ago (2016-11-15 13:48:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 13:51:01 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:34:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a36eaea4b6d788fef2b3073d327a7fc33849acd
Cr-Commit-Position: refs/heads/master@{#40993}

Powered by Google App Engine
This is Rietveld 408576698