Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 249833002: Split ActivityLogging attributes in IDLExtendedAttributes. (Closed)

Created:
6 years, 8 months ago by Devlin
Modified:
6 years, 8 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, gasubic, eae+blinkwatch, fs, eric.carlson_apple.com, nessy, adamk+blink_chromium.org, rwlbuis, Nils Barth (inactive), arv+blink, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, ojan, sof, philipj_slow, timvolodine, feature-media-reviews_chromium.org, Nate Chapin, vcarbune.chromium, gavinp+prerender_chromium.org, jsbell+bindings_chromium.org, kouhei+bindings_chromium.org, mvanouwerkerk+watch_chromium.org, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Split ActivityLogging attributes in IDLExtendedAttributes. The new format is: LogActivity=|GetterOnly|SetterOnly LogAllWorlds LogActivity defaults to logging both Getter and Setter, or Method, as appropriate. LogAllWorlds, if present, means that logging will occur in both isolated worlds and the main world. If absent, logging will occur only in isolated worlds. Split off from https://codereview.chromium.org/213783002/ BUG=366167 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172452

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -104 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 2 chunks +2 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 1 chunk +9 lines, -12 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/dom/Document.idl View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/Element.idl View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/GlobalEventHandlers.idl View 1 chunk +22 lines, -22 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Location.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/Window.idl View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLButtonElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLHtmlElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLModElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLQuoteElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLScriptElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSourceElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTrackElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/storage/Storage.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/geolocation/Geolocation.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/WindowWebDatabase.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Devlin
All, split this off from https://codereview.chromium.org/213783002/ at Nils's request. Please take a look.
6 years, 8 months ago (2014-04-23 18:05:50 UTC) #1
haraken
This CL doesn't change any existing behavior, so is not controversial at all. LGTM.
6 years, 8 months ago (2014-04-24 00:43:07 UTC) #2
Nils Barth (inactive)
LGTM, thanks for splitting off and revisions!
6 years, 8 months ago (2014-04-24 00:46:33 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 8 months ago (2014-04-24 00:46:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/249833002/20001
6 years, 8 months ago (2014-04-24 00:47:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 01:23:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-24 01:23:11 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 8 months ago (2014-04-24 02:27:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/249833002/20001
6 years, 8 months ago (2014-04-24 02:28:08 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 03:01:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-24 03:01:34 UTC) #11
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 8 months ago (2014-04-24 03:46:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/249833002/20001
6 years, 8 months ago (2014-04-24 03:46:26 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 04:17:14 UTC) #14
Message was sent while issue was closed. 
Change committed as 172452

Powered by Google App Engine
This is Rietveld 408576698