CrOS md user row adjustments

ash/common/system/user/rounded_image_view.h

Index: ash/common/system/user/rounded_image_view.h
diff --git a/ash/common/system/user/rounded_image_view.h b/ash/common/system/user/rounded_image_view.h
index fd3e21adfc847a6ac6efc42fc295da90fd567034..ad5d47a7874dfb3a8fe26b4b95d05fc0829079a4 100644
--- a/ash/common/system/user/rounded_image_view.h
+++ b/ash/common/system/user/rounded_image_view.h
@@ -44,6 +44,7 @@ class RoundedImageView : public views::View {
 
   // True if the given user is the active user and the icon should get
   // painted as active.
+  // TODO(estade): remove this, it's not used in Material Design.

[tdanderson, 2016/11/16 23:08:08]

nit: please add crbug.com/614453

[Evan Stade, 2016/11/17 00:37:50]

so the reason I don't add that religiously is because I have a pretty good grasp
of how to remove pre-md stuff --- I had a whole lot of practice on top Chrome
--- and as long as the word "material" is somewhere nearby, it won't be hard to
grep for.

On the other hand, if all you ever grep for is that bug number, you'll miss a
whole lot of stuff that should be removed.

[tdanderson, 2016/11/17 01:40:15]

The plan is to grep for a) places that are gated with something in
MaterialDesignController, and b) the bug number. If this is something that is in
your opinion easily discovered with a) (even if you are not necessarily the one
who will be doing the cleanup in this file) then please disregard (now and in
all future times I may make the same suggestion).

[Evan Stade, 2016/11/17 01:54:18]

one reason a) and b) are not sufficient alone is because as you change code you
need to change a lot of comments as well. Many comments reference differences
between MD and non-MD, but do not reference that bug, and the compiler would not
complain if you removed IsShelfMaterial() but didn't touch the comments.

Thus I think the best approach is grepping for "material" and "md" (which covers
comments, function names like DoFooMd, and
MaterialDesignController::IsFooMaterial, and has very few false positives), and
making sure that grepping for those two things is sufficient. At that point, the
bug number is superfluous.

   bool active_user_;
 
   DISALLOW_COPY_AND_ASSIGN(RoundedImageView);