arc: enable use_new_wrapper_types for intent_helper.mojom

arc: enable use_new_wrapper_types for intent_helper.mojom

BUG=662510
BUG=624136
TEST=try

Committed: https://crrev.com/e6db796a2f93afe3913d9c84c1760b51d1652360
Cr-Commit-Position: refs/heads/master@{#432499}

[Yusuke Sato, 2016-11-15 01:39:01]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 01:40:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 01:48:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 01:48:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Yusuke Sato, 2016-11-15 02:15:40]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 02:16:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 03:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 03:39:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yusuke Sato, 2016-11-15 04:16:43]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 04:17:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 05:56:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 05:56:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yusuke Sato, 2016-11-15 18:00:40]

Description was changed from

==========
arc: enable use_new_wrapper_types for arc/intent_heler/

BUG=662510
TEST=try
==========

to

==========
arc: enable use_new_wrapper_types for intent_helper.mojom

BUG=662510
TEST=try
==========

[Yusuke Sato, 2016-11-15 18:24:01]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 18:24:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-11-15 18:56:19]

Description was changed from

==========
arc: enable use_new_wrapper_types for intent_helper.mojom

BUG=662510
TEST=try
==========

to

==========
arc: enable use_new_wrapper_types for intent_helper.mojom

BUG=662510
BUG=624136
TEST=try
==========

[commit-bot: I haz the power, 2016-11-15 19:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 19:40:02]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-11-15 23:53:44]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 23:54:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-11-15 23:54:40]

yusukes@chromium.org changed reviewers:
+ kinaba@chromium.org, lhchavez@chromium.org

[Yusuke Sato, 2016-11-15 23:54:41]

PTAL too.

kinaba: chrome/browser/chromeos/file_manager/
Luis: everything else

Thanks!

[commit-bot: I haz the power, 2016-11-16 02:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 02:47:22]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-11-16 03:22:02]

lgtm with nits. Feel free to punt/delegate the typemaps.

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc
(right):

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc:24:
const char kArcUrl[] = "content://org.chromium.foo/bar";
can this be constexpr?

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
(right):

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc:25:
const char kArcUrl[] = "content://org.chromium.foo/bar";
nit: also constexpr

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
(right):

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc:8:
#include <utility>
nit: remove utility, vector

https://codereview.chromium.org/2498223002/diff/80001/components/arc/intent_h...
File components/arc/intent_helper/intent_filter.cc (right):

https://codereview.chromium.org/2498223002/diff/80001/components/arc/intent_h...
components/arc/intent_helper/intent_filter.cc:13:
IntentFilter::IntentFilter(const mojom::IntentFilterPtr& mojo_intent_filter) {
This looks like another candidate for typemaps.

https://codereview.chromium.org/2498223002/diff/80001/components/arc/intent_h...
File components/arc/intent_helper/link_handler_model_impl.cc (right):

https://codereview.chromium.org/2498223002/diff/80001/components/arc/intent_h...
components/arc/intent_helper/link_handler_model_impl.cc:9: #include <vector>
nit: remove?

[kinaba, 2016-11-16 03:25:40]

wow this is great. file_manager/ lgtm

[Yusuke Sato, 2016-11-16 06:01:55]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 06:02:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-11-16 06:10:21]

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc
(right):

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util_unittest.cc:24:
const char kArcUrl[] = "content://org.chromium.foo/bar";
On 2016/11/16 03:22:02, Luis Héctor Chávez wrote:
> can this be constexpr?

Done.

(according to https://chromium-cpp.appspot.com/, we're not supposed to rewrite
existing code, but doing it at small-scale upon request seems just fine.)

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
(right):

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc:25:
const char kArcUrl[] = "content://org.chromium.foo/bar";
On 2016/11/16 03:22:02, Luis Héctor Chávez wrote:
> nit: also constexpr

Done.

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
(right):

https://codereview.chromium.org/2498223002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc:8:
#include <utility>
On 2016/11/16 03:22:02, Luis Héctor Chávez wrote:
> nit: remove utility, vector

Done.

https://codereview.chromium.org/2498223002/diff/80001/components/arc/intent_h...
File components/arc/intent_helper/intent_filter.cc (right):

https://codereview.chromium.org/2498223002/diff/80001/components/arc/intent_h...
components/arc/intent_helper/intent_filter.cc:13:
IntentFilter::IntentFilter(const mojom::IntentFilterPtr& mojo_intent_filter) {
On 2016/11/16 03:22:02, Luis Héctor Chávez wrote:
> This looks like another candidate for typemaps.

Added TODO and filed a bug.

https://codereview.chromium.org/2498223002/diff/80001/components/arc/intent_h...
File components/arc/intent_helper/link_handler_model_impl.cc (right):

https://codereview.chromium.org/2498223002/diff/80001/components/arc/intent_h...
components/arc/intent_helper/link_handler_model_impl.cc:9: #include <vector>
On 2016/11/16 03:22:02, Luis Héctor Chávez wrote:
> nit: remove?

Done.

[Yusuke Sato, 2016-11-16 06:48:39]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-11-16 06:48:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, kinaba@chromium.org
Link to the patchset: https://codereview.chromium.org/2498223002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-16 06:48:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 10:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 10:50:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yusuke Sato, 2016-11-16 15:08:47]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2016-11-16 15:09:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 15:45:11]

Description was changed from

==========
arc: enable use_new_wrapper_types for intent_helper.mojom

BUG=662510
BUG=624136
TEST=try
==========

to

==========
arc: enable use_new_wrapper_types for intent_helper.mojom

BUG=662510
BUG=624136
TEST=try
==========

[commit-bot: I haz the power, 2016-11-16 15:45:12]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-16 15:48:16]

Description was changed from

==========
arc: enable use_new_wrapper_types for intent_helper.mojom

BUG=662510
BUG=624136
TEST=try
==========

to

==========
arc: enable use_new_wrapper_types for intent_helper.mojom

BUG=662510
BUG=624136
TEST=try

Committed: https://crrev.com/e6db796a2f93afe3913d9c84c1760b51d1652360
Cr-Commit-Position: refs/heads/master@{#432499}
==========

[commit-bot: I haz the power, 2016-11-16 15:48:21]

Patchset 7 (id:??) landed as
https://crrev.com/e6db796a2f93afe3913d9c84c1760b51d1652360
Cr-Commit-Position: refs/heads/master@{#432499}