[DevTools] contextCreated should be called when context initialization is done

[DevTools] contextCreated should be called when context initialization is done

Inspector can evaluate and run debugger internal scripts in contextCreated method.

BUG=chromium:663845
R=dgozman@chromium.org

Committed: https://crrev.com/7f48b5bcde47df6852eb72e5f4be3a21f149e0d0
Cr-Commit-Position: refs/heads/master@{#432923}

[kozy, 2016-11-15 01:32:19]

Dmitry, please take a look.

[dgozman, 2016-11-15 01:34:06]

lgtm

[kozy, 2016-11-15 01:34:47]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-11-15 01:34:48]

Pavel, please take a look. I need owner lgtm.

[kozy, 2016-11-15 01:34:53]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 01:35:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 04:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 04:25:00]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-11-16 23:50:03]

lgtm

[kozy, 2016-11-16 23:53:37]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-11-16 23:55:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 02:19:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:19:09]

Failed to apply patch for
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp:180
  error:
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp:
patch does not apply

Patch:      
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
Index:
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
diff --git
a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
index
8d5e856037c0700411d6491a2ad4283947464ed3..d98f16af8c6e7612dfe18cee978c693876c200d9
100644
---
a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
+++
b/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
@@ -180,14 +180,6 @@ bool
WorkerOrWorkletScriptController::initializeContextIfNeeded() {
 
   ScriptState::Scope scope(m_scriptState.get());
 
-  // Name new context for debugging. For main thread worklet global scopes
-  // this is done once the context is initialized.
-  if (m_globalScope->isWorkerGlobalScope() ||
-      m_globalScope->isThreadedWorkletGlobalScope()) {
-    WorkerThreadDebugger* debugger = WorkerThreadDebugger::from(m_isolate);
-    debugger->contextCreated(m_globalScope->thread(), context);
-  }
-
   // The global proxy object.  Note this is not the global object.
   v8::Local<v8::Object> globalProxy = context->Global();
   // The global object, aka worker/worklet wrapper object.
@@ -200,6 +192,14 @@ bool
WorkerOrWorkletScriptController::initializeContextIfNeeded() {
   // So we explicitly call constructorForType for the global object.
   V8PerContextData::from(context)->constructorForType(wrapperTypeInfo);
 
+  // Name new context for debugging. For main thread worklet global scopes
+  // this is done once the context is initialized.
+  if (m_globalScope->isWorkerGlobalScope() ||
+      m_globalScope->isThreadedWorkletGlobalScope()) {
+    WorkerThreadDebugger* debugger = WorkerThreadDebugger::from(m_isolate);
+    debugger->contextCreated(m_globalScope->thread(), context);
+  }
+
   return true;
 }

[kozy, 2016-11-17 16:37:11]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-17 16:37:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2498213002/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2016-11-17 16:37:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 18:38:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 20:28:05]

Description was changed from

==========
[DevTools] contextCreated should be called when context initialization is done

Inspector can evaluate and run debugger internal scripts in contextCreated
method.

BUG=chromium:663845
R=dgozman@chromium.org
==========

to

==========
[DevTools] contextCreated should be called when context initialization is done

Inspector can evaluate and run debugger internal scripts in contextCreated
method.

BUG=chromium:663845
R=dgozman@chromium.org

Committed: https://crrev.com/7f48b5bcde47df6852eb72e5f4be3a21f149e0d0
Cr-Commit-Position: refs/heads/master@{#432923}
==========

[commit-bot: I haz the power, 2016-11-17 20:28:06]

Patchset 2 (id:??) landed as
https://crrev.com/7f48b5bcde47df6852eb72e5f4be3a21f149e0d0
Cr-Commit-Position: refs/heads/master@{#432923}