Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2498193003: [WIP not ready for review] ServiceWorker Download support.

Created:
4 years, 1 month ago by horo
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, asanka, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, Randy Smith (Not in Mondays), rginda+watch_chromium.org, darin-cc_chromium.org, loading-reviews_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP not ready for review] ServiceWorker Download support. BUG=468227 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -47 lines) Patch
M content/browser/download/download_manager_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 9 chunks +22 lines, -4 lines 0 comments Download
M content/browser/download/save_file_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_message_filter.h View 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_message_filter.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 2 3 4 3 chunks +14 lines, -8 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 4 2 chunks +26 lines, -6 lines 0 comments Download
M content/browser/loader/resource_requester_info.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_requester_info.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M content/common/frame_messages.h View 1 2 3 4 2 chunks +10 lines, -6 lines 0 comments Download
M content/public/browser/download_url_parameters.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/download_url_parameters.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
horo
Description was changed from ========== [WIP not ready for review] ServiceWorker Download support. BUG=468227 ========== ...
4 years, 1 month ago (2016-11-15 13:33:10 UTC) #1
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-17 11:50:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498193003/60001
4 years, 1 month ago (2016-11-17 11:50:14 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-17 12:06:13 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/264211)
4 years, 1 month ago (2016-11-17 12:06:14 UTC) #5
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-18 09:30:58 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498193003/80001
4 years, 1 month ago (2016-11-18 09:31:20 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-18 09:48:37 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 09:48:38 UTC) #9 
Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698