Cleanup cfwl_* files.

xfa/fde/cfde_txtedtengine.h

Index: xfa/fde/cfde_txtedtengine.h
diff --git a/xfa/fde/cfde_txtedtengine.h b/xfa/fde/cfde_txtedtengine.h
index 8f0e855f52272a58325211ed5f0a8aa620b99f4c..587402d4143a3247244fc798b77dc9e5f79db863 100644
--- a/xfa/fde/cfde_txtedtengine.h
+++ b/xfa/fde/cfde_txtedtengine.h
@@ -31,7 +31,9 @@ class CFDE_TxtEdtEngine {
   void SetTextByStream(IFX_Stream* pStream);
   void SetText(const CFX_WideString& wsText);
   int32_t GetTextLength() const;
-  void GetText(CFX_WideString& wsText, int32_t nStart, int32_t nCount = -1);
+  void GetText(CFX_WideString& wsText,

[Tom Sepez, 2016/11/15 18:44:59]

if wsText is an out parameter, its cleaner to return it instead of void.

[dsinclair, 2016/11/15 19:10:23]

Follow up. There are a lot of methods that take out params when they should just
return. I'm going to tackle them in a later Cl.

+               int32_t nStart,
+               int32_t nCount = -1) const;
   void ClearText();
 
   int32_t GetCaretRect(CFX_RectF& rtCaret) const;
@@ -57,8 +59,8 @@ class CFDE_TxtEdtEngine {
   void RemoveSelRange(int32_t nStart, int32_t nCount = -1);
 
   void AddSelRange(int32_t nStart, int32_t nCount = -1);
-  int32_t CountSelRanges();
-  int32_t GetSelRange(int32_t nIndex, int32_t& nStart);
+  int32_t CountSelRanges() const;
+  int32_t GetSelRange(int32_t nIndex, int32_t& nStart) const;

[Tom Sepez, 2016/11/15 18:44:59]

Can this return a FDE_TXTEDITSELRANGE instead of one scalar value and an out
param?  Ick.

[dsinclair, 2016/11/15 19:10:23]

Acknowledged.

   void ClearSelection();
 
   bool Redo(const IFDE_TxtEdtDoRecord* pRecord);
@@ -126,7 +128,7 @@ class CFDE_TxtEdtEngine {
   bool ReplaceParagEnd(FX_WCHAR*& lpText,
                        int32_t& nLength,
                        bool bPreIsCR = false);
-  void RecoverParagEnd(CFX_WideString& wsText);
+  void RecoverParagEnd(CFX_WideString& wsText) const;

[Tom Sepez, 2016/11/15 18:44:59]

ditto

[dsinclair, 2016/11/15 19:10:23]

Acknowledged.

   int32_t MovePage2Char(int32_t nIndex);
   void TextPos2ParagPos(int32_t nIndex, FDE_TXTEDTPARAGPOS& ParagPos) const;
   int32_t MoveForward(bool& bBefore);