Cleanup cfwl_* files.

xfa/fde/cfde_txtedtengine.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FDE_CFDE_TXTEDTENGINE_H_
 #define XFA_FDE_CFDE_TXTEDTENGINE_H_
 
 #include <memory>
@@ skipping 13 matching lines @@
 
   void SetEditParams(const FDE_TXTEDTPARAMS& params);
   FDE_TXTEDTPARAMS* GetEditParams();
 
   int32_t CountPages() const;
   IFDE_TxtEdtPage* GetPage(int32_t nIndex);
 
   void SetTextByStream(IFX_Stream* pStream);
   void SetText(const CFX_WideString& wsText);
   int32_t GetTextLength() const;
-  void GetText(CFX_WideString& wsText, int32_t nStart, int32_t nCount = -1);
+  void GetText(CFX_WideString& wsText,

[Tom Sepez, 2016/11/15 18:44:59]

if wsText is an out parameter, its cleaner to return it instead of void.

[dsinclair, 2016/11/15 19:10:23]

Follow up. There are a lot of methods that take out params when they should just
return. I'm going to tackle them in a later Cl.

+               int32_t nStart,
+               int32_t nCount = -1) const;
   void ClearText();
 
   int32_t GetCaretRect(CFX_RectF& rtCaret) const;
   int32_t GetCaretPos() const;
   int32_t SetCaretPos(int32_t nIndex, bool bBefore);
   int32_t MoveCaretPos(FDE_TXTEDTMOVECARET eMoveCaret,
                        bool bShift = false,
                        bool bCtrl = false);
   void Lock();
   void Unlock();
   bool IsLocked() const;
 
   int32_t Insert(int32_t nStart, const FX_WCHAR* lpText, int32_t nLength);
   int32_t Delete(int32_t nStart, bool bBackspace = false);
   int32_t DeleteRange(int32_t nStart, int32_t nCount = -1);
   int32_t Replace(int32_t nStart,
                   int32_t nLength,
                   const CFX_WideString& wsReplace);
 
   void SetLimit(int32_t nLimit);
   void SetAliasChar(FX_WCHAR wcAlias);
 
   void RemoveSelRange(int32_t nStart, int32_t nCount = -1);
 
   void AddSelRange(int32_t nStart, int32_t nCount = -1);
-  int32_t CountSelRanges();
-  int32_t GetSelRange(int32_t nIndex, int32_t& nStart);
+  int32_t CountSelRanges() const;
+  int32_t GetSelRange(int32_t nIndex, int32_t& nStart) const;

[Tom Sepez, 2016/11/15 18:44:59]

Can this return a FDE_TXTEDITSELRANGE instead of one scalar value and an out
param?  Ick.

[dsinclair, 2016/11/15 19:10:23]

Acknowledged.

   void ClearSelection();
 
   bool Redo(const IFDE_TxtEdtDoRecord* pRecord);
   bool Undo(const IFDE_TxtEdtDoRecord* pRecord);
 
   int32_t StartLayout();
   int32_t DoLayout(IFX_Pause* pPause);
   void EndLayout();
 
   bool Optimize(IFX_Pause* pPause = nullptr);
@@ skipping 47 matching lines @@
   void RebuildParagraphs();
   void RemoveAllParags();
   void RemoveAllPages();
   void UpdateParags();
   void UpdatePages();
   void UpdateTxtBreak();
 
   bool ReplaceParagEnd(FX_WCHAR*& lpText,
                        int32_t& nLength,
                        bool bPreIsCR = false);
-  void RecoverParagEnd(CFX_WideString& wsText);
+  void RecoverParagEnd(CFX_WideString& wsText) const;

[Tom Sepez, 2016/11/15 18:44:59]

ditto

[dsinclair, 2016/11/15 19:10:23]

Acknowledged.

   int32_t MovePage2Char(int32_t nIndex);
   void TextPos2ParagPos(int32_t nIndex, FDE_TXTEDTPARAGPOS& ParagPos) const;
   int32_t MoveForward(bool& bBefore);
   int32_t MoveBackward(bool& bBefore);
   bool MoveUp(CFX_PointF& ptCaret);
   bool MoveDown(CFX_PointF& ptCaret);
   bool MoveLineStart();
   bool MoveLineEnd();
   bool MoveParagStart();
   bool MoveParagEnd();
@@ skipping 29 matching lines @@
   bool m_bLock;
   int32_t m_nLimit;
   FX_WCHAR m_wcAliasChar;
   int32_t m_nFirstLineEnd;
   bool m_bAutoLineEnd;
   FX_WCHAR m_wLineEnd;
   FDE_TXTEDT_TEXTCHANGE_INFO m_ChangeInfo;
 };
 
 #endif  // XFA_FDE_CFDE_TXTEDTENGINE_H_