Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2498153004: exo: Improve benchmark support in motion event client. (Closed)

Created:
4 years, 1 month ago by reveman
Modified:
4 years, 1 month ago
Reviewers:
Daniele Castagna
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Improve benchmark support in motion event client. It adds a kBenchmarkWarmupFrames constant and rendering of a number of frames before we start benchmark measurements. --benchmark=RUNS can be used to perform a number of benchmark runs. Each will print the result as a tab separated list to standard output that is easy to parse in a shell script. Client will exit after performing all runs. --benchmark-interval=MS can be used specify length of each benchmark run in milliseconds. BUG=661010 Committed: https://crrev.com/73a9f66a9a89f66628ea6554f33750f3a17fd823 Cr-Commit-Position: refs/heads/master@{#432400}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -31 lines) Patch
M components/exo/wayland/clients/motion_events.cc View 1 10 chunks +78 lines, -31 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
reveman
4 years, 1 month ago (2016-11-15 18:36:30 UTC) #2
Daniele Castagna
LGTM. Again, you can be a little bit more descriptive in the CL description.
4 years, 1 month ago (2016-11-15 18:40:07 UTC) #3
reveman
On 2016/11/15 at 18:40:07, dcastagna wrote: > LGTM. > Again, you can be a little ...
4 years, 1 month ago (2016-11-15 21:32:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498153004/20001
4 years, 1 month ago (2016-11-15 21:33:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261078)
4 years, 1 month ago (2016-11-15 21:51:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498153004/20001
4 years, 1 month ago (2016-11-15 22:10:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261176)
4 years, 1 month ago (2016-11-15 22:40:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498153004/20001
4 years, 1 month ago (2016-11-16 04:03:45 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 06:37:45 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:39:38 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73a9f66a9a89f66628ea6554f33750f3a17fd823
Cr-Commit-Position: refs/heads/master@{#432400}

Powered by Google App Engine
This is Rietveld 408576698