Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2498153003: Reland: Show the tutorial during OOBE (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Show the tutorial during OOBE Original issue https://codereview.chromium.org/2497723002/ Revert was speculative; reland is speculative TBR=dtseng@chromium.org Committed: https://crrev.com/8292e619f94f0fa361a17b40e450556a0bcf6f9c Cr-Commit-Position: refs/heads/master@{#432260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498153003/1
4 years, 1 month ago (2016-11-15 21:05:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 21:41:04 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8292e619f94f0fa361a17b40e450556a0bcf6f9c Cr-Commit-Position: refs/heads/master@{#432260}
4 years, 1 month ago (2016-11-15 21:44:35 UTC) #11
horo
4 years, 1 month ago (2016-11-16 02:11:52 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2507543004/ by horo@chromium.org.

The reason for reverting is: failed again.
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C...

BUG=664881.

Powered by Google App Engine
This is Rietveld 408576698