[MD Settings][MD User Manager] create/manage profile desktop shortcut (Windows only)

chrome/browser/resources/md_user_manager/create_profile.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'create-profile' is a page that contains controls for creating
  * a (optionally supervised) profile, including choosing a name, and an avatar.
  */
 
 /** @typedef {{url: string, label:string}} */
@@ skipping 72 matching lines @@
     /**
      * The current error/warning message.
      * @private {string}
      */
     message_: {
       type: String,
       value: ''
     },
 
     /**
+     * if true, a desktop shortcut will be created for the new profile.
+     * @private {boolean}
+     */
+    createShortcut_: {
+      type: Boolean,
+      value: false

[tommycli, 2016/11/15 01:59:50]

Can you double check on Windows whether it is indeed false by default? I thought
I remembered it being true by default:

https://www.youtube.com/watch?v=QHRVHL_Ts9Y&t=1m40s

[Moe, 2016/11/15 16:03:10]

You're right. It has to be true by default.

+    },
+
+    /**
      * True if the new profile is a supervised profile.
      * @private {boolean}
      */
     isSupervised_: {
       type: Boolean,
       value: false
     },
 
     /**
      * The list of usernames and profile paths for currently signed-in users.
      * @private {!Array<!SignedInUser>}
      */
     signedInUsers_: {
       type: Array,
       value: function() { return []; }
     },
 
     /**
      * Index of the selected signed-in user.
      * @private {number}
      */
     signedInUserIndex_: {
       type: Number,
       value: NO_USER_SELECTED
     },
 
     /** @private {!signin.ProfileBrowserProxy} */
-    browserProxy_: Object
+    browserProxy_: Object,
+
+    /**
+     * True if the profile shortcuts feature is enabled.
+     * @private
+     */
+    isProfileShortcutsEnabled_: {
+      type: Boolean,
+      value: function() {
+        return loadTimeData.getBoolean('profileShortcutsEnabled');
+      },
+      readOnly: true
+    }
   },
 
   listeners: {
     'tap': 'onTap_',
     'importUserPopup.import': 'onImportUserPopupImport_'
   },
 
   /** @override */
   created: function() {
     this.browserProxy_ = signin.ProfileBrowserProxyImpl.getInstance();
@@ skipping 217 matching lines @@
    */
   createProfile_: function() {
     var custodianProfilePath = '';
     if (this.signedInUserIndex_ != NO_USER_SELECTED) {
       custodianProfilePath =
           this.signedInUser_(this.signedInUserIndex_).profilePath;
     }
     this.hideMessage_();
     this.createInProgress_ = true;
     this.browserProxy_.createProfile(
-        this.profileName_, this.profileIconUrl_, this.isSupervised_, '',
-        custodianProfilePath);
+        this.profileName_, this.profileIconUrl_, this.createShortcut_,
+        this.isSupervised_, '', custodianProfilePath);
   },
 
   /**
    * Handler for the 'import' event fired by #importUserPopup once a supervised
    * user is selected to be imported and the popup closes.
    * @param {!{detail: {supervisedUser: !SupervisedUser,
    *                    signedInUser: !SignedInUser}}} event
    * @private
    */
   onImportUserPopupImport_: function(event) {
     var supervisedUser = event.detail.supervisedUser;
     var signedInUser = event.detail.signedInUser;
     this.hideMessage_();
     this.createInProgress_ = true;
     this.browserProxy_.createProfile(
-        supervisedUser.name, supervisedUser.iconURL, true, supervisedUser.id,
-        signedInUser.profilePath);
+        supervisedUser.name, supervisedUser.iconURL, false, true,

[tommycli, 2016/11/15 01:59:50]

Maybe inline comment the param names...

false /* createShortcut */, true /* isSupervised */

[Moe, 2016/11/15 16:03:10]

Done.

+        supervisedUser.id, signedInUser.profilePath);
   },
 
   /**
    * Handler for the 'Cancel' button tap event.
    * @param {!Event} event
    * @private
    */
   onCancelTap_: function(event) {
     if (this.createInProgress_) {
       this.createInProgress_ = false;
@@ skipping 121 matching lines @@
    * Computed binding that returns True if there are any signed-in users.
    * @param {!Array<!SignedInUser>} signedInUsers signed-in users.
    * @return {boolean}
    * @private
    */
   isSignedIn_: function(signedInUsers) {
     return signedInUsers.length > 0;
   }
 });
 }());