Add markPromiseAsHandled V8 extra util

Add markPromiseAsHandled V8 extra util

This will allow V8 extra consumers to mark a promise as handled without
adding redundant empty onRejected handlers. This is needed by streams as
discussed in https://github.com/whatwg/streams/issues/547.

BUG=chromium:654701
Committed: https://crrev.com/2f060955e881aad0e6d5124c533403d3b172bb3b
Cr-Commit-Position: refs/heads/master@{#41012}

[domenic, 2016-11-14 23:11:02]

domenic@chromium.org changed reviewers:
+ gsathya@chromium.org

[gsathya, 2016-11-14 23:21:23]

gsathya@chromium.org changed reviewers:
+ littledan@chromium.org

[gsathya, 2016-11-14 23:21:23]

lgtm

+littledan for OWNERS

[domenic, 2016-11-14 23:31:22]

The CQ bit was checked by domenic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 23:31:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 00:46:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 00:46:04]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-11-15 10:34:39]

lgtm

Are there unit tests for things exposed to v8-extras?

https://codereview.chromium.org/2498143002/diff/1/src/js/promise.js
File src/js/promise.js (right):

https://codereview.chromium.org/2498143002/diff/1/src/js/promise.js#newcode592
src/js/promise.js:592: }
I like factoring this out into a separate function. It'd be great to do a quick
find/replace of this line to make it call out to this function, but understand
if you want to leave that refactoring for a later patch.

[Dan Ehrenberg, 2016-11-15 10:35:14]

https://codereview.chromium.org/2498143002/diff/1/src/js/promise.js
File src/js/promise.js (right):

https://codereview.chromium.org/2498143002/diff/1/src/js/promise.js#newcode640
src/js/promise.js:640: "markPromiseAsHandled", MarkPromiseAsHandled
Maybe add a trailing comma here so that future patches don't have to touch
earlier unaffected lines.

[gsathya, 2016-11-15 10:39:08]

On 2016/11/15 10:34:39, Dan Ehrenberg wrote:
> lgtm
> 
> Are there unit tests for things exposed to v8-extras?
> 
> https://codereview.chromium.org/2498143002/diff/1/src/js/promise.js
> File src/js/promise.js (right):
> 
> https://codereview.chromium.org/2498143002/diff/1/src/js/promise.js#newcode592
> src/js/promise.js:592: }
> I like factoring this out into a separate function. It'd be great to do a
quick
> find/replace of this line to make it call out to this function, but understand
> if you want to leave that refactoring for a later patch.

Might be better to leave it as such, since all of this is going away soon
anyway.

[domenic, 2016-11-15 16:38:05]

On 2016/11/15 at 10:34:39, littledan wrote:
> lgtm
> 
> Are there unit tests for things exposed to v8-extras?

There are:
https://cs.chromium.org/chromium/src/v8/test/cctest/test-api.cc?q=extras+test...
which relies on
https://cs.chromium.org/chromium/src/v8/test/cctest/test-extra.js.

I didn't realize that the C++-side API had a simple HasHandler() boolean. That
makes this much easier to test than I thought it would be. Let me add some
tests.

[domenic, 2016-11-15 20:59:31]

The CQ bit was checked by domenic@chromium.org

[domenic, 2016-11-15 20:59:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org, gsathya@chromium.org
Link to the patchset: https://codereview.chromium.org/2498143002/#ps20001
(title: "Add tests")

[commit-bot: I haz the power, 2016-11-15 20:59:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:25:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:35:09]

Description was changed from

==========
Add markPromiseAsHandled V8 extra util

This will allow V8 extra consumers to mark a promise as handled without
adding redundant empty onRejected handlers. This is needed by streams as
discussed in https://github.com/whatwg/streams/issues/547.

BUG=chromium:654701
==========

to

==========
Add markPromiseAsHandled V8 extra util

This will allow V8 extra consumers to mark a promise as handled without
adding redundant empty onRejected handlers. This is needed by streams as
discussed in https://github.com/whatwg/streams/issues/547.

BUG=chromium:654701

Committed: https://crrev.com/2f060955e881aad0e6d5124c533403d3b172bb3b
Cr-Commit-Position: refs/heads/master@{#41012}
==========

[commit-bot: I haz the power, 2016-11-17 22:35:10]

Patchset 2 (id:??) landed as
https://crrev.com/2f060955e881aad0e6d5124c533403d3b172bb3b
Cr-Commit-Position: refs/heads/master@{#41012}