Connect analyzer's AnalysisError object to front_end's CompilationError.

Connect analyzer's AnalysisError object to front_end's CompilationError.

AnalysisError implements CompilationError but provides additional
services, such as extensibility via the `getProperty` method.

Note: CompilationError.location has been renamed to
CompilationError.span to avoid confusion (since its type is
`SourceSpan`, not `SourceLocation`).

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/fc5270df72d47daf68e16b8985591d40f3ee264a

[Paul Berry, 2016-11-14 23:02:45]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-11-14 23:16:15]

LGTM

[Paul Berry, 2016-11-14 23:30:14]

Description was changed from

==========
Connect analyzer's AnalysisError object to front_end's CompilationError.

AnalysisError implements CompilationError but provides additional
services, such as extensibility via the `getProperty` method.

Note: CompilationError.location has been renamed to
CompilationError.span to avoid confusion (since its type is
`SourceSpan`, not `SourceLocation`).
==========

to

==========
Connect analyzer's AnalysisError object to front_end's CompilationError.

AnalysisError implements CompilationError but provides additional
services, such as extensibility via the `getProperty` method.

Note: CompilationError.location has been renamed to
CompilationError.span to avoid confusion (since its type is
`SourceSpan`, not `SourceLocation`).

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fc5270df72d47daf68e16b8985591d40f3ee264a
==========

[Paul Berry, 2016-11-14 23:30:15]

Committed patchset #1 (id:1) manually as
fc5270df72d47daf68e16b8985591d40f3ee264a (presubmit successful).

[Brian Wilkerson, 2016-11-14 23:34:41]

https://codereview.chromium.org/2498133002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/source_io.dart (right):

https://codereview.chromium.org/2498133002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/source_io.dart:242: new
source_span.SourceFile(file.readAsStringSync(), url: uri);
I haven't thought this through completely, but this (and similar code in
FileSource) is somewhat concerning.
(1) If the content has been overlaid, then this could return a SourceFile with
the wrong content.
(2) Because sources are light-weight objects, we might end up reading the file
multiple times, even though it's cached in one source object.
(3) Because it's cached, it won't be recreated if the content changes (either on
disk or as an overlay).

https://codereview.chromium.org/2498133002/diff/1/pkg/front_end/lib/compilati...
File pkg/front_end/lib/compilation_error.dart (right):

https://codereview.chromium.org/2498133002/diff/1/pkg/front_end/lib/compilati...
pkg/front_end/lib/compilation_error.dart:21: /// The source location where the
error occurred.
"location" --> "span"?

[Paul Berry, 2016-11-15 16:54:05]

On 2016/11/14 23:34:41, Brian Wilkerson wrote:
>
https://codereview.chromium.org/2498133002/diff/1/pkg/analyzer/lib/src/genera...
> File pkg/analyzer/lib/src/generated/source_io.dart (right):
> 
>
https://codereview.chromium.org/2498133002/diff/1/pkg/analyzer/lib/src/genera...
> pkg/analyzer/lib/src/generated/source_io.dart:242: new
> source_span.SourceFile(file.readAsStringSync(), url: uri);
> I haven't thought this through completely, but this (and similar code in
> FileSource) is somewhat concerning.
> (1) If the content has been overlaid, then this could return a SourceFile with
> the wrong content.
> (2) Because sources are light-weight objects, we might end up reading the file
> multiple times, even though it's cached in one source object.
> (3) Because it's cached, it won't be recreated if the content changes (either
on
> disk or as an overlay).
> 
>
https://codereview.chromium.org/2498133002/diff/1/pkg/front_end/lib/compilati...
> File pkg/front_end/lib/compilation_error.dart (right):
> 
>
https://codereview.chromium.org/2498133002/diff/1/pkg/front_end/lib/compilati...
> pkg/front_end/lib/compilation_error.dart:21: /// The source location where the
> error occurred.
> "location" --> "span"?

Good points.  I will re-think this and do a follow-up CL.