[Win] Redesign the avatar bubble UI

[Win] Redesign the avatar bubble UI

Mocks: https://docs.google.com/a/google.com/file/d/0BxMIIGI80eU-VW16NEloUFdyaXc/edit

This CL is related to its Mac cousin, https://codereview.chromium.org/235833002/.
Like the related CL, this one also does not implement the "round" avatar icon, nor the
top-left corner info button, but it does set up the layout for the other elements.

I've also added the option to be able to center the text in a textfield.

BUG=353398
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266447

[noms (inactive), 2014-04-23 17:50:59]

Hiya Scott!

Here is (yet another) UI redesign to the avatar bubble. I've also added a new
method to the views Textfield which lets you center the text in the control, as
I didn't see it exposed. Please take a look! Thanks.

[sky, 2014-04-23 20:40:52]

https://codereview.chromium.org/249813002/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/249813002/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:103: class
BlankImageSource : public gfx::CanvasImageSource {
Why do you need this? Can't you either set a null image, or if you really need
an image create a real image without needing a CanvasImageSource?

[noms (inactive), 2014-04-24 14:29:23]

https://codereview.chromium.org/249813002/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/249813002/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:103: class
BlankImageSource : public gfx::CanvasImageSource {
The placeholder image needs to have the same size as the hover image (so that
when you hover it maintains the layout).  A null image wouldn't have this set
size, and I haven't found out a different way to create an empty image of a set
size otherwise. 

(Unless by "real image" you mean a transparent physical png of the right size --
I thought that would be more annoying, I guess)

On 2014/04/23 20:40:53, sky wrote:
> Why do you need this? Can't you either set a null image, or if you really need
> an image create a real image without needing a CanvasImageSource?

[sky, 2014-04-24 16:27:44]

https://codereview.chromium.org/249813002/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/249813002/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:103: class
BlankImageSource : public gfx::CanvasImageSource {
On 2014/04/24 14:29:23, Monica Dinculescu wrote:
> The placeholder image needs to have the same size as the hover image (so that
> when you hover it maintains the layout).  A null image wouldn't have this set
> size, and I haven't found out a different way to create an empty image of a
set
> size otherwise. 
> 
> (Unless by "real image" you mean a transparent physical png of the right size
--
> I thought that would be more annoying, I guess)
> 
> On 2014/04/23 20:40:53, sky wrote:
> > Why do you need this? Can't you either set a null image, or if you really
need
> > an image create a real image without needing a CanvasImageSource?
> 

https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/image/image...

[noms (inactive), 2014-04-24 17:06:56]

https://codereview.chromium.org/249813002/diff/1/chrome/browser/ui/views/prof...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right):

https://codereview.chromium.org/249813002/diff/1/chrome/browser/ui/views/prof...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:103: class
BlankImageSource : public gfx::CanvasImageSource {
AH, that makes sense. Thanks! Done.

On 2014/04/24 16:27:45, sky wrote:
> On 2014/04/24 14:29:23, Monica Dinculescu wrote:
> > The placeholder image needs to have the same size as the hover image (so
that
> > when you hover it maintains the layout).  A null image wouldn't have this
set
> > size, and I haven't found out a different way to create an empty image of a
> set
> > size otherwise. 
> > 
> > (Unless by "real image" you mean a transparent physical png of the right
size
> --
> > I thought that would be more annoying, I guess)
> > 
> > On 2014/04/23 20:40:53, sky wrote:
> > > Why do you need this? Can't you either set a null image, or if you really
> need
> > > an image create a real image without needing a CanvasImageSource?
> > 
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/image/image...

[sky, 2014-04-24 18:15:24]

Thanks, LGTM

[noms (inactive), 2014-04-24 18:17:42]

Sweet! Thanks.

On 2014/04/24 18:15:24, sky wrote:
> Thanks, LGTM

[noms (inactive), 2014-04-24 18:17:53]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-04-24 21:52:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/249813002/20001

[commit-bot: I haz the power, 2014-04-24 23:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 23:07:18]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[noms (inactive), 2014-04-25 14:01:01]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-04-25 21:45:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/249813002/40001

[commit-bot: I haz the power, 2014-04-25 23:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:11:13]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[noms (inactive), 2014-04-26 00:41:53]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-04-26 00:44:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/249813002/40001

[commit-bot: I haz the power, 2014-04-26 07:42:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 07:42:43]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[noms (inactive), 2014-04-27 20:09:44]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-04-27 20:10:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/249813002/40001

[commit-bot: I haz the power, 2014-04-28 06:41:58]

Change committed as 266447