Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: components/google/core/browser/google_util_unittest.cc

Issue 2498113003: Add verification that google URL has a valid TLD. (Closed)
Patch Set: Change implementation to set. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "components/google/core/browser/google_switches.h" 8 #include "components/google/core/browser/google_switches.h"
9 #include "components/google/core/browser/google_url_tracker.h" 9 #include "components/google/core/browser/google_url_tracker.h"
10 #include "components/google/core/browser/google_util.h" 10 #include "components/google/core/browser/google_util.h"
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 // Test some good Google domains (valid TLDs). 232 // Test some good Google domains (valid TLDs).
233 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.com"), 233 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.com"),
234 google_util::ALLOW_SUBDOMAIN, 234 google_util::ALLOW_SUBDOMAIN,
235 google_util::DISALLOW_NON_STANDARD_PORTS)); 235 google_util::DISALLOW_NON_STANDARD_PORTS));
236 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://google.com"), 236 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://google.com"),
237 google_util::ALLOW_SUBDOMAIN, 237 google_util::ALLOW_SUBDOMAIN,
238 google_util::DISALLOW_NON_STANDARD_PORTS)); 238 google_util::DISALLOW_NON_STANDARD_PORTS));
239 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.ca"), 239 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.ca"),
240 google_util::ALLOW_SUBDOMAIN, 240 google_util::ALLOW_SUBDOMAIN,
241 google_util::DISALLOW_NON_STANDARD_PORTS)); 241 google_util::DISALLOW_NON_STANDARD_PORTS));
242 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.biz.tj"), 242 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.off.ai"),
243 google_util::ALLOW_SUBDOMAIN, 243 google_util::ALLOW_SUBDOMAIN,
244 google_util::DISALLOW_NON_STANDARD_PORTS)); 244 google_util::DISALLOW_NON_STANDARD_PORTS));
245 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.com/search?q=thing"), 245 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.com/search?q=thing"),
246 google_util::ALLOW_SUBDOMAIN, 246 google_util::ALLOW_SUBDOMAIN,
247 google_util::DISALLOW_NON_STANDARD_PORTS)); 247 google_util::DISALLOW_NON_STANDARD_PORTS));
248 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.com/webhp"), 248 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://www.google.com/webhp"),
249 google_util::ALLOW_SUBDOMAIN, 249 google_util::ALLOW_SUBDOMAIN,
250 google_util::DISALLOW_NON_STANDARD_PORTS)); 250 google_util::DISALLOW_NON_STANDARD_PORTS));
251 251
252 // Test some bad Google domains (invalid TLDs). 252 // Test some bad Google domains (invalid/non-Google TLDs).
253 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://www.google.notrealtld"), 253 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://www.google.notrealtld"),
254 google_util::ALLOW_SUBDOMAIN, 254 google_util::ALLOW_SUBDOMAIN,
255 google_util::DISALLOW_NON_STANDARD_PORTS)); 255 google_util::DISALLOW_NON_STANDARD_PORTS));
256 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://www.google.sd"),
257 google_util::ALLOW_SUBDOMAIN,
258 google_util::DISALLOW_NON_STANDARD_PORTS));
256 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://www.google.faketld/search?q=q"), 259 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://www.google.faketld/search?q=q"),
257 google_util::ALLOW_SUBDOMAIN, 260 google_util::ALLOW_SUBDOMAIN,
258 google_util::DISALLOW_NON_STANDARD_PORTS)); 261 google_util::DISALLOW_NON_STANDARD_PORTS));
259 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://www.yahoo.com"), 262 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://www.yahoo.com"),
260 google_util::ALLOW_SUBDOMAIN, 263 google_util::ALLOW_SUBDOMAIN,
261 google_util::DISALLOW_NON_STANDARD_PORTS)); 264 google_util::DISALLOW_NON_STANDARD_PORTS));
265 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://www.google.biz.tj"),
266 google_util::ALLOW_SUBDOMAIN,
267 google_util::DISALLOW_NON_STANDARD_PORTS));
262 268
263 // Test subdomain checks. 269 // Test subdomain checks.
264 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://images.google.com"), 270 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://images.google.com"),
265 google_util::ALLOW_SUBDOMAIN, 271 google_util::ALLOW_SUBDOMAIN,
266 google_util::DISALLOW_NON_STANDARD_PORTS)); 272 google_util::DISALLOW_NON_STANDARD_PORTS));
267 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://images.google.com"), 273 EXPECT_FALSE(IsGoogleDomainUrl(GURL("http://images.google.com"),
268 google_util::DISALLOW_SUBDOMAIN, 274 google_util::DISALLOW_SUBDOMAIN,
269 google_util::DISALLOW_NON_STANDARD_PORTS)); 275 google_util::DISALLOW_NON_STANDARD_PORTS));
270 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://google.com"), 276 EXPECT_TRUE(IsGoogleDomainUrl(GURL("http://google.com"),
271 google_util::DISALLOW_SUBDOMAIN, 277 google_util::DISALLOW_SUBDOMAIN,
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 EXPECT_FALSE(IsYoutubeDomainUrl(GURL("http://www.youtube.com:123"), 422 EXPECT_FALSE(IsYoutubeDomainUrl(GURL("http://www.youtube.com:123"),
417 google_util::DISALLOW_SUBDOMAIN, 423 google_util::DISALLOW_SUBDOMAIN,
418 google_util::DISALLOW_NON_STANDARD_PORTS)); 424 google_util::DISALLOW_NON_STANDARD_PORTS));
419 EXPECT_TRUE(IsYoutubeDomainUrl(GURL("http://www.youtube.com:123"), 425 EXPECT_TRUE(IsYoutubeDomainUrl(GURL("http://www.youtube.com:123"),
420 google_util::DISALLOW_SUBDOMAIN, 426 google_util::DISALLOW_SUBDOMAIN,
421 google_util::ALLOW_NON_STANDARD_PORTS)); 427 google_util::ALLOW_NON_STANDARD_PORTS));
422 EXPECT_FALSE(IsYoutubeDomainUrl(GURL("file://www.youtube.com"), 428 EXPECT_FALSE(IsYoutubeDomainUrl(GURL("file://www.youtube.com"),
423 google_util::DISALLOW_SUBDOMAIN, 429 google_util::DISALLOW_SUBDOMAIN,
424 google_util::DISALLOW_NON_STANDARD_PORTS)); 430 google_util::DISALLOW_NON_STANDARD_PORTS));
425 } 431 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698