Fix potential GPU crash caused by VT switching

Fix potential GPU crash caused by VT switching

When display control is released Frecon may change the configuration at
will. Since Chrome never stops page flipping, there is a race condition
when Chrome regains control where the Chrome hasn't polled for the
configuration but is still page flipping which leads to a failed page
flip due to invalid display configuration (which causes the GPU process
to be killed).

Turning the displays off unparents the windows from the displays
allowing Chrome to continue page flipping while the display
configuration is renewed.

BUG=655770
TEST=Updated display_unittests

Committed: https://crrev.com/547665586e0d17adc9d8ecf03b41c9448fe7719c
Cr-Commit-Position: refs/heads/master@{#432177}

[dnicoara, 2016-11-14 22:19:09]

dnicoara@chromium.org changed reviewers:
+ dbehr@chromium.org, derat@chromium.org

[dnicoara, 2016-11-14 22:19:09]

PTAL

derat@ for OWNERS
dbehr@ FYI

[dnicoara, 2016-11-14 22:19:14]

The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 22:21:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-11-14 22:44:43]

lgtm

https://codereview.chromium.org/2498103002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.h (right):

https://codereview.chromium.org/2498103002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.h:384: // Helper function that sends
the actual command.
please document what "success" is, since it's unclear from the method signature,
e.g. "|success| is the result of RelinquishControl's SetDisplayPowerInternal
call."

[dnicoara, 2016-11-14 22:51:45]

https://codereview.chromium.org/2498103002/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.h (right):

https://codereview.chromium.org/2498103002/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.h:384: // Helper function that sends
the actual command.
On 2016/11/14 22:44:43, Daniel Erat wrote:
> please document what "success" is, since it's unclear from the method
signature,
> e.g. "|success| is the result of RelinquishControl's SetDisplayPowerInternal
> call."

Done.

[dnicoara, 2016-11-14 22:51:53]

The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 22:53:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 23:42:23]

Dry run: This issue passed the CQ dry run.

[dnicoara, 2016-11-15 14:48:04]

The CQ bit was checked by dnicoara@chromium.org

[dnicoara, 2016-11-15 14:48:04]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2498103002/#ps20001
(title: "Add doc")

[commit-bot: I haz the power, 2016-11-15 14:48:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 14:52:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 14:54:46]

Description was changed from

==========
Fix potential GPU crash caused by VT switching

When display control is released Frecon may change the configuration at
will. Since Chrome never stops page flipping, there is a race condition
when Chrome regains control where the Chrome hasn't polled for the
configuration but is still page flipping which leads to a failed page
flip due to invalid display configuration (which causes the GPU process
to be killed).

Turning the displays off unparents the windows from the displays
allowing Chrome to continue page flipping while the display
configuration is renewed.

BUG=655770
TEST=Updated display_unittests
==========

to

==========
Fix potential GPU crash caused by VT switching

When display control is released Frecon may change the configuration at
will. Since Chrome never stops page flipping, there is a race condition
when Chrome regains control where the Chrome hasn't polled for the
configuration but is still page flipping which leads to a failed page
flip due to invalid display configuration (which causes the GPU process
to be killed).

Turning the displays off unparents the windows from the displays
allowing Chrome to continue page flipping while the display
configuration is renewed.

BUG=655770
TEST=Updated display_unittests

Committed: https://crrev.com/547665586e0d17adc9d8ecf03b41c9448fe7719c
Cr-Commit-Position: refs/heads/master@{#432177}
==========

[commit-bot: I haz the power, 2016-11-15 14:54:47]

Patchset 2 (id:??) landed as
https://crrev.com/547665586e0d17adc9d8ecf03b41c9448fe7719c
Cr-Commit-Position: refs/heads/master@{#432177}