GrAtlas cleanup: Split out GrPlot and GrAtlas

GrAtlas cleanup: Split out GrPlot and GrAtlas

This breaks up GrAtlas into the head of the list (GrAtlas) and the list elements (GrPlot). It also moves all of the GrPlot management code into GrAtlasMgr. It adds a simple pool allocator for GrPlots and removes use of GrPlotMgr.

Committed: http://code.google.com/p/skia/source/detail?r=11508

[jvanverth1, 2013-09-27 15:05:25]

I have a change in process that removes GrPlotMgr, but it increases the flush
count for reasons I don't quite understand. So... one more step on the way.

[jvanverth1, 2013-09-27 18:36:49]

Updated with the fixed pool allocator.

This should be ready to go, PTAL.

[bsalomon, 2013-09-27 18:42:55]

lgtm w/ a comment suggestion and nit

https://codereview.chromium.org/24981004/diff/3001/src/gpu/GrAtlas.cpp
File src/gpu/GrAtlas.cpp (right):

https://codereview.chromium.org/24981004/diff/3001/src/gpu/GrAtlas.cpp#newcod...
src/gpu/GrAtlas.cpp:101: adjustForOffset(loc, fOffset);
this->

https://codereview.chromium.org/24981004/diff/3001/src/gpu/GrAtlas.h
File src/gpu/GrAtlas.h (right):

https://codereview.chromium.org/24981004/diff/3001/src/gpu/GrAtlas.h#newcode56
src/gpu/GrAtlas.h:56: GrPlot* addToAtlas(GrAtlas*, int width, int height, const
void*, GrIPoint16*);
This guy could really use a comment describing what does.

[jvanverth1, 2013-09-27 19:12:53]

Addressed. I also added a comment to the top of GrAtlas.h, PTAL.

https://codereview.chromium.org/24981004/diff/3001/src/gpu/GrAtlas.cpp
File src/gpu/GrAtlas.cpp (right):

https://codereview.chromium.org/24981004/diff/3001/src/gpu/GrAtlas.cpp#newcod...
src/gpu/GrAtlas.cpp:101: adjustForOffset(loc, fOffset);
On 2013/09/27 18:42:55, bsalomon wrote:
> this->

It's static -- renamed the function.

https://codereview.chromium.org/24981004/diff/3001/src/gpu/GrAtlas.h
File src/gpu/GrAtlas.h (right):

https://codereview.chromium.org/24981004/diff/3001/src/gpu/GrAtlas.h#newcode56
src/gpu/GrAtlas.h:56: GrPlot* addToAtlas(GrAtlas*, int width, int height, const
void*, GrIPoint16*);
On 2013/09/27 18:42:55, bsalomon wrote:
> This guy could really use a comment describing what does.

Done.

[bsalomon, 2013-09-27 19:30:59]

lgtm feel free to ignore my suggestion.

https://codereview.chromium.org/24981004/diff/8001/src/gpu/GrAtlas.h
File src/gpu/GrAtlas.h (right):

https://codereview.chromium.org/24981004/diff/8001/src/gpu/GrAtlas.h#newcode23
src/gpu/GrAtlas.h:23: // a GrAtlas needs space on the texture, it requests a
GrPlot. Each GrAtlas can be made up of one
Maybe instead of "can be made up of" say "can own" or "can claim"?

[commit-bot: I haz the power, 2013-09-27 19:33:40]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jvanverth@google.com/24981004/18001

[commit-bot: I haz the power, 2013-09-27 19:39:55]

Change committed as 11508