Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: tests/language/vm/optimized_unique_selector_test.dart

Issue 2498073004: AOT: Fix bug in receiver type propagation after unique selector calls. (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_range_analysis.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/vm/optimized_unique_selector_test.dart
diff --git a/tests/language/vm/optimized_unique_selector_test.dart b/tests/language/vm/optimized_unique_selector_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..bf0b5e4d71caebbc6e7df112c01205813ab6b07a
--- /dev/null
+++ b/tests/language/vm/optimized_unique_selector_test.dart
@@ -0,0 +1,42 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+
+class A {
+ _uniqueSelector() { }
+ final uniqueField = 10;
+}
+
+test1(obj) {
+ var res = 0;
+ for (var i = 0; i < 2; i++) {
+ obj._uniqueSelector();
+ res += obj.uniqueField; // This load must not be hoisted out of the loop.
+ }
+ return res;
+}
+
+test2(obj) {
+ final objAlias = obj;
+ closure() => objAlias;
+ var res = 0;
+ for (var i = 0; i < 2; i++) {
+ obj._uniqueSelector();
+ res += objAlias.uniqueField; // This load must not be hoisted out of the loop.
+ }
+ return res;
+}
+
+var foofoo_ = test1;
+
+main () {
+ Expect.equals(20, foofoo_(new A()));
+ Expect.throws(() => foofoo_(0));
+
+ foofoo_ = test2;
+
+ Expect.equals(20, foofoo_(new A()));
+ Expect.throws(() => foofoo_(0));
+}
« no previous file with comments | « runtime/vm/flow_graph_range_analysis.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698