Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2498073003: Fix GPU service and display initialization race. (Closed)

Created:
4 years, 1 month ago by kylechar
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, sadrul, James Cook
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GPU service and display initialization race. When running mustash on device with Ozone, display initialization was happening before GPU service initialization was finished. The DRM thread wasn't ready when DrmNativeDisplayDelegate went to use it. The problem was made much worse by crrev.com/2484223006 when display initialization was moved so it started earlier. With this patch, we start display initialization when it's known to be safe. BUG=659804 Committed: https://crrev.com/3e7dcd6974ae2895ba6cc2f38141c90338d20fc7 Cr-Commit-Position: refs/heads/master@{#432388}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix empty line. #

Patch Set 3 : Make function abstract. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M services/ui/service.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/service.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M services/ui/ws/test_utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/window_server.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/ws/window_server_delegate.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
kylechar
4 years, 1 month ago (2016-11-15 19:22:33 UTC) #2
sky
LGTM https://codereview.chromium.org/2498073003/diff/1/services/ui/service.cc File services/ui/service.cc (right): https://codereview.chromium.org/2498073003/diff/1/services/ui/service.cc#newcode231 services/ui/service.cc:231: remove empty line.
4 years, 1 month ago (2016-11-15 19:53:05 UTC) #3
kylechar
Thanks sky! https://codereview.chromium.org/2498073003/diff/1/services/ui/service.cc File services/ui/service.cc (right): https://codereview.chromium.org/2498073003/diff/1/services/ui/service.cc#newcode231 services/ui/service.cc:231: On 2016/11/15 19:53:05, sky wrote: > remove ...
4 years, 1 month ago (2016-11-15 20:00:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498073003/40001
4 years, 1 month ago (2016-11-16 03:48:35 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 06:24:51 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:29:47 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3e7dcd6974ae2895ba6cc2f38141c90338d20fc7
Cr-Commit-Position: refs/heads/master@{#432388}

Powered by Google App Engine
This is Rietveld 408576698