Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: src/interpreter/interpreter-assembler.cc

Issue 2498073002: [refactoring] Split CodeAssemblerState out of CodeAssembler (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/interpreter-assembler.cc
diff --git a/src/interpreter/interpreter-assembler.cc b/src/interpreter/interpreter-assembler.cc
index c8ce5539e9d78b0ed0f3f393386c76e345011eb5..6395463ec600d2faac85dfc20cc177f855627d56 100644
--- a/src/interpreter/interpreter-assembler.cc
+++ b/src/interpreter/interpreter-assembler.cc
@@ -20,15 +20,13 @@ namespace v8 {
namespace internal {
namespace interpreter {
+using compiler::CodeAssemblerState;
Jakob Kummerow 2016/11/15 09:51:50 I'll drop this in a new patch set (or use it every
Michael Starzinger 2016/11/15 11:45:20 I think it is fine to use here (or somewhere else
Igor Sheludko 2016/11/15 13:06:35 I also think it's fine to use "using" declaration
Jakob Kummerow 2016/11/15 13:40:32 Done.
using compiler::Node;
-InterpreterAssembler::InterpreterAssembler(Isolate* isolate, Zone* zone,
+InterpreterAssembler::InterpreterAssembler(compiler::CodeAssemblerState* state,
Igor Sheludko 2016/11/15 13:06:35 ... and you can drop the compiler:: part here.
Jakob Kummerow 2016/11/15 13:40:32 Right, that's what I meant. Done.
Bytecode bytecode,
OperandScale operand_scale)
- : CodeStubAssembler(isolate, zone, InterpreterDispatchDescriptor(isolate),
- Code::ComputeFlags(Code::BYTECODE_HANDLER),
- Bytecodes::ToString(bytecode),
- Bytecodes::ReturnCount(bytecode)),
+ : CodeStubAssembler(state),
bytecode_(bytecode),
operand_scale_(operand_scale),
bytecode_offset_(this, MachineType::PointerRepresentation()),

Powered by Google App Engine
This is Rietveld 408576698