Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: src/builtins/builtins-iterator.cc

Issue 2498073002: [refactoring] Split CodeAssemblerState out of CodeAssembler (Closed)
Patch Set: one more attempt Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins-internal.cc ('k') | src/builtins/builtins-math.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/builtins/builtins-utils.h" 5 #include "src/builtins/builtins-utils.h"
6 #include "src/builtins/builtins.h" 6 #include "src/builtins/builtins.h"
7 #include "src/frames-inl.h" 7 #include "src/frames-inl.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
11 11
12 void Builtins::Generate_IteratorPrototypeIterator( 12 void Builtins::Generate_IteratorPrototypeIterator(
13 CodeStubAssembler* assembler) { 13 compiler::CodeAssemblerState* state) {
14 assembler->Return(assembler->Parameter(0)); 14 CodeStubAssembler assembler(state);
15 assembler.Return(assembler.Parameter(0));
15 } 16 }
16 17
17 BUILTIN(ModuleNamespaceIterator) { 18 BUILTIN(ModuleNamespaceIterator) {
18 HandleScope scope(isolate); 19 HandleScope scope(isolate);
19 DCHECK_EQ(1, args.length()); 20 DCHECK_EQ(1, args.length());
20 Handle<Object> receiver = args.at<Object>(0); 21 Handle<Object> receiver = args.at<Object>(0);
21 22
22 if (!receiver->IsJSModuleNamespace()) { 23 if (!receiver->IsJSModuleNamespace()) {
23 THROW_NEW_ERROR_RETURN_FAILURE( 24 THROW_NEW_ERROR_RETURN_FAILURE(
24 isolate, NewTypeError(MessageTemplate::kIncompatibleMethodReceiver, 25 isolate, NewTypeError(MessageTemplate::kIncompatibleMethodReceiver,
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } else { 60 } else {
60 value = isolate->factory()->undefined_value(); 61 value = isolate->factory()->undefined_value();
61 done = true; 62 done = true;
62 } 63 }
63 64
64 return *isolate->factory()->NewJSIteratorResult(value, done); 65 return *isolate->factory()->NewJSIteratorResult(value, done);
65 } 66 }
66 67
67 } // namespace internal 68 } // namespace internal
68 } // namespace v8 69 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins-internal.cc ('k') | src/builtins/builtins-math.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698