Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: components/search_engines/default_search_manager_unittest.cc

Issue 2498053002: Add field to monitor last visited time for each search engine (Closed)
Patch Set: Add unit test for last_visited field. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/default_search_manager_unittest.cc
diff --git a/components/search_engines/default_search_manager_unittest.cc b/components/search_engines/default_search_manager_unittest.cc
index 49aa45c4a8ad6f7fd1c4aa2964f62035423c223d..33930a584de2aa1ac90e91936663993ae2732c2a 100644
--- a/components/search_engines/default_search_manager_unittest.cc
+++ b/components/search_engines/default_search_manager_unittest.cc
@@ -29,7 +29,8 @@ const char kDefaultSearchProviderData[] =
"default_search_provider_data.template_url_data";
// Checks that the two TemplateURLs are similar. Does not check the id, the
-// date_created or the last_modified time. Neither pointer should be NULL.
+// date_created, the last_modified time or the last_visited time. Neither
Peter Kasting 2016/11/21 03:35:08 Nit: See earlier comment about wording
ltian 2016/11/28 22:08:02 Done.
+// pointer should be NULL.
void ExpectSimilar(const TemplateURLData* expected,
const TemplateURLData* actual) {
ASSERT_TRUE(expected != NULL);
@@ -137,6 +138,7 @@ std::unique_ptr<TemplateURLData> GenerateDummyTemplateURLData(
"UTF-8;UTF-16", ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
data->date_created = base::Time();
data->last_modified = base::Time();
+ data->last_visited = base::Time();
return data;
}
@@ -178,6 +180,7 @@ TEST_F(DefaultSearchManagerTest, ReadAndWritePref) {
"UTF-8;UTF-16", ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
data.date_created = base::Time();
data.last_modified = base::Time();
+ data.last_modified = base::Time();
manager.SetUserSelectedDefaultSearchEngine(data);
TemplateURLData* read_data = manager.GetDefaultSearchEngine(NULL);

Powered by Google App Engine
This is Rietveld 408576698