Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 249803002: Preserve identical values for background-size and -webkit-mask-size. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/masking/parsing-mask-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 7cc5f9a6fdb34e495578fb5337ecd9bd3036dbfc..96588feed050c025d2a5d82fdd01b987507b5275 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -2845,7 +2845,12 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSPropertyParser::parseFillSize(CSSPropertyID
if (!parsedValue2)
return parsedValue1;
- return createPrimitiveValuePair(parsedValue1.release(), parsedValue2.release());
+
+ // For backwards compatibility.
ojan 2014/04/24 01:12:38 This comment seems somewhat lacking in context. Ei
andersr 2014/04/24 11:05:42 OK, I removed it.
+ Pair::IdenticalValuesPolicy policy = propId == CSSPropertyWebkitBackgroundSize ?
+ Pair::DropIdenticalValues : Pair::KeepIdenticalValues;
+
+ return createPrimitiveValuePair(parsedValue1.release(), parsedValue2.release(), policy);
}
bool CSSPropertyParser::parseFillProperty(CSSPropertyID propId, CSSPropertyID& propId1, CSSPropertyID& propId2,
« no previous file with comments | « LayoutTests/fast/masking/parsing-mask-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698