Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2498023002: [Devtools] Fixed hover color in waterfall in darktheme (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed hover color in waterfall in darktheme Fixes a bug when in dark theme the color is set to partial transparent showing background color items in network waterfall when hovered on header. R=dgozman,lushnikov BUG=664888 Committed: https://crrev.com/465b1a02c3b38ad5cbd2df44461653b0137fca9f Cr-Commit-Position: refs/heads/master@{#431990}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/network/networkLogView.css View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 11 (6 generated)
allada
PTL https://codereview.chromium.org/2498023002/diff/1/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css File third_party/WebKit/Source/devtools/front_end/network/networkLogView.css (right): https://codereview.chromium.org/2498023002/diff/1/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css#newcode352 third_party/WebKit/Source/devtools/front_end/network/networkLogView.css:352: background-color: hsl(0, 0%, 90%); See: .data-grid th:hover in ...
4 years, 1 month ago (2016-11-14 18:24:09 UTC) #2
dgozman
lgtm
4 years, 1 month ago (2016-11-14 20:33:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2498023002/1
4 years, 1 month ago (2016-11-14 21:16:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 23:54:17 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:02:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/465b1a02c3b38ad5cbd2df44461653b0137fca9f
Cr-Commit-Position: refs/heads/master@{#431990}

Powered by Google App Engine
This is Rietveld 408576698