MD Settings: Suppress the signout dialog if user is not signed in.

MD Settings: Suppress the signout dialog if user is not signed in.

Recently we added the /signOut route for the navigable sign out dialog.

This created problems, since the user can navigate there by URL
(or have the URL in history) even if the user is not signed in.

This CL adds logic to exit the sign out dialog route if the user is not
signed in.

BUG=661965
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/be82f91e1f87efcdb4328cb463db5359accb7e73
Cr-Commit-Position: refs/heads/master@{#432236}

[tommycli, 2016-11-14 23:44:53]

Description was changed from

==========
MD Settings: Suppress the signout dialog if user is not signed in.

Recently we added the /signOut route for the navigable sign out dialog.

This created problems, since the user can navigate there by URL
(or have the URL in history) even if the user is not signed in.

This CL adds logic to exit the sign out dialog route if the user is not
signed in.

BUG=661965
==========

to

==========
MD Settings: Suppress the signout dialog if user is not signed in.

Recently we added the /signOut route for the navigable sign out dialog.

This created problems, since the user can navigate there by URL
(or have the URL in history) even if the user is not signed in.

This CL adds logic to exit the sign out dialog route if the user is not
signed in.

BUG=661965
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-11-14 23:48:33]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-11-14 23:48:34]

dbeam: PTAL, this fixes some wonkiness with users being able to access the
/signOut route even if not signed in.

[Dan Beam, 2016-11-15 01:30:46]

lgtm but can haz tests?

[tommycli, 2016-11-15 17:45:30]

dbeam: Thanks! I added a test. (And also fixed one source of test flakiness)

[tommycli, 2016-11-15 17:45:34]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 17:46:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-15 19:11:40]

lgtm

[tommycli, 2016-11-15 19:11:47]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-11-15 19:11:47]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-11-15 19:11:56]

On 2016/11/15 19:11:40, Dan Beam wrote:
> lgtm

Thank you! sending it in.

[commit-bot: I haz the power, 2016-11-15 19:12:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 19:50:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-15 20:20:21]

Description was changed from

==========
MD Settings: Suppress the signout dialog if user is not signed in.

Recently we added the /signOut route for the navigable sign out dialog.

This created problems, since the user can navigate there by URL
(or have the URL in history) even if the user is not signed in.

This CL adds logic to exit the sign out dialog route if the user is not
signed in.

BUG=661965
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Suppress the signout dialog if user is not signed in.

Recently we added the /signOut route for the navigable sign out dialog.

This created problems, since the user can navigate there by URL
(or have the URL in history) even if the user is not signed in.

This CL adds logic to exit the sign out dialog route if the user is not
signed in.

BUG=661965
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/be82f91e1f87efcdb4328cb463db5359accb7e73
Cr-Commit-Position: refs/heads/master@{#432236}
==========

[commit-bot: I haz the power, 2016-11-15 20:20:22]

Patchset 3 (id:??) landed as
https://crrev.com/be82f91e1f87efcdb4328cb463db5359accb7e73
Cr-Commit-Position: refs/heads/master@{#432236}